QueryCache: Support queries with totals and extremes by rschu1ze · Pull Request #48853 · ClickHouse/ClickHouse

rschu1ze · 2023-04-17T14:45:42Z

Changelog category (leave one):

Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

The query cache can now supports queries with totals and extremes modifier.

rschu1ze · 2023-04-24T15:05:51Z

Looks like I made pretty much every mistake with pipeline processors one can make (at least I learned something) but the latest version seems to work. Let me rebase, cleanup and add a test.

rschu1ze · 2023-04-24T22:17:40Z

@nickitat You are the only reviewer I can think of for this PR. Would you like to have a look? Thanks!

The logic is admittedly a bit tricky. In case of questions, please ask.

alexey-milovidov · 2023-04-26T22:08:02Z

@rschu1ze, is it related to the query cache?

https://s3.amazonaws.com/clickhouse-test-reports/48853/4dceee0dc321445ef420b5e37aac69805b40fcc7/upgrade_check__msan_/logical_errors.txt

src/Processors/Sources/SourceFromChunks.cpp

robot-ch-test-poll4 · 2023-05-05T16:08:39Z

This is an automated comment for commit bba85c9 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	🟢 success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟢 success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	🟢 success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	🟢 success
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🔴 failure
Mergeable Check	Checks if all other necessary checks are successful	🟢 success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	🟢 success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	🟢 success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🔴 failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	🔴 failure
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	🟢 success
Unit tests	Runs the unit tests for different release types	🟢 success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	🟢 success

nickitat · 2023-05-05T16:53:36Z

src/Interpreters/Cache/QueryCache.h

    public:
        bool hasCacheEntryForKey() const;
-        Pipe && getPipe(); /// must be called only if hasCacheEntryForKey() returns true
+        std::unique_ptr<SourceFromChunks> getSource();


maybe add a comment that these methods shouldn't be called more then once

Done, thanks.

rschu1ze · 2023-05-06T13:41:03Z

ClickHouse Stateless Tests (release, Wide Parts Enabled):
ClickHouse Stateless Tests (msan) [6/6]:
ClickHouse Stateless Tests (debug) [5/5]:
ClickHouse Stateless Tests (aarch64):

02723_zookeeper_name: also occurs in master (missing ORDER BY), will try to fix separately

ClickHouse Stateless Tests (release, Analyzer)

the many test failures also occur in master (all unrelated)

ClickHouse Integration Tests (release) [2/4]

test_merge_tree_s3/test.py::test_store_cleanup_disk_s3[node]: test_store_cleanup_disk_s3 is flaky #48691

rschu1ze · 2023-05-06T14:50:43Z

02723_zookeeper_name: also occurs in master (missing ORDER BY), will try to fix separately

--> #49594

rschu1ze mentioned this pull request Apr 17, 2023

Don't use the query cache for queries with totals/extremes #48717

Closed

rschu1ze marked this pull request as draft April 17, 2023 14:48

robot-clickhouse added the pr-improvement Pull request with some product improvements label Apr 17, 2023

rschu1ze force-pushed the rs/qc-totals-extremes2 branch 8 times, most recently from 5fa3a98 to 3dfa9c7 Compare April 24, 2023 15:02

rschu1ze marked this pull request as ready for review April 24, 2023 15:02

rschu1ze changed the title ~~(wip) QueryCache: Support totals and extremes~~ QueryCache: Support totals and extremes Apr 24, 2023

rschu1ze force-pushed the rs/qc-totals-extremes2 branch 7 times, most recently from 8061eb1 to 674cbc4 Compare April 24, 2023 22:12

rschu1ze changed the title ~~QueryCache: Support totals and extremes~~ QueryCache: Support queries with totals and extremes Apr 24, 2023

nickitat self-assigned this Apr 24, 2023

Support totals and extremes in query cache

b565257

rschu1ze force-pushed the rs/qc-totals-extremes2 branch from 674cbc4 to b565257 Compare April 24, 2023 22:23

Merge branch 'master' into rs/qc-totals-extremes2

4dceee0

nickitat reviewed Apr 26, 2023

View reviewed changes

src/Processors/Sources/SourceFromChunks.cpp Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/master' into rs/qc-totals-extremes2

aba5db4

rschu1ze force-pushed the rs/qc-totals-extremes2 branch from 0c49cfa to 32dde2a Compare May 5, 2023 16:09

Simplify simplify simplify

945a513

rschu1ze force-pushed the rs/qc-totals-extremes2 branch from 32dde2a to 945a513 Compare May 5, 2023 16:30

nickitat approved these changes May 5, 2023

View reviewed changes

Improve docs

bba85c9

rschu1ze merged commit 983e370 into master May 6, 2023

rschu1ze deleted the rs/qc-totals-extremes2 branch May 6, 2023 13:41

rschu1ze mentioned this pull request May 6, 2023

Mark query cache as non-experimental #47977

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

QueryCache: Support queries with totals and extremes#48853

QueryCache: Support queries with totals and extremes#48853
rschu1ze merged 5 commits intomasterfrom
rs/qc-totals-extremes2

rschu1ze commented Apr 17, 2023 •

edited

Loading

Uh oh!

rschu1ze commented Apr 24, 2023 •

edited

Loading

Uh oh!

rschu1ze commented Apr 24, 2023 •

edited

Loading

Uh oh!

alexey-milovidov commented Apr 26, 2023

Uh oh!

Uh oh!

robot-ch-test-poll4 commented May 5, 2023 •

edited by robot-clickhouse-ci-2

Loading

Uh oh!

nickitat May 5, 2023

Uh oh!

rschu1ze May 5, 2023

Uh oh!

rschu1ze commented May 6, 2023

Uh oh!

rschu1ze commented May 6, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

rschu1ze commented Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Uh oh!

rschu1ze commented Apr 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rschu1ze commented Apr 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexey-milovidov commented Apr 26, 2023

Uh oh!

Uh oh!

robot-ch-test-poll4 commented May 5, 2023 • edited by robot-clickhouse-ci-2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickitat May 5, 2023

Choose a reason for hiding this comment

Uh oh!

rschu1ze May 5, 2023

Choose a reason for hiding this comment

Uh oh!

rschu1ze commented May 6, 2023

Uh oh!

rschu1ze commented May 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rschu1ze commented Apr 17, 2023 •

edited

Loading

rschu1ze commented Apr 24, 2023 •

edited

Loading

rschu1ze commented Apr 24, 2023 •

edited

Loading

robot-ch-test-poll4 commented May 5, 2023 •

edited by robot-clickhouse-ci-2

Loading

rschu1ze commented May 6, 2023 •

edited

Loading