Conversation
1d8049a to
f29d154
Compare
a418fc1 to
ee14e29
Compare
serxa
reviewed
Apr 21, 2023
4577a93 to
18803b9
Compare
serxa
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is now possible to limit the query cache usage of individual users using settings profiles and settings constraints. More specifically, you can restrict the maximum amount of memory (in bytes) a user may allocate in the query cache and the the maximum number of stored query results. For that, first provide configurations
query_cache_max_sizeandquery_cache_max_entriesin a user profile inusers.xml, then make both settings readonly:The main motivation is to prevent users from spamming the cache, i.e. evicting other user's query results. Other internal caches are generally also vulnerable to such misuse but the query cache makes misuse particularly easy.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
It is now possible to define per-user quotas in the query cache