Skip to content

Rename cfg parameter query_cache.size to query_cache.max_size#47724

Merged
alexey-milovidov merged 2 commits intomasterfrom
rs/qc-better-cfg-name
Mar 26, 2023
Merged

Rename cfg parameter query_cache.size to query_cache.max_size#47724
alexey-milovidov merged 2 commits intomasterfrom
rs/qc-better-cfg-name

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Mar 19, 2023

This PR fixes a little naming ambiguity. It adds a max_ prefix to a size setting to make it more clear that the cache consumes no space if not used.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@rschu1ze rschu1ze added the do not test disable testing on pull request label Mar 19, 2023
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 19, 2023
Add 'max_' prefix to 'size' setting to make it more clear that the cache
consumes no space if not used.
@rschu1ze rschu1ze force-pushed the rs/qc-better-cfg-name branch from 4c9bb43 to 0712627 Compare March 24, 2023 12:52
@rschu1ze rschu1ze removed the do not test disable testing on pull request label Mar 24, 2023
@rschu1ze rschu1ze changed the title (wip) Rename cfg parameter query_cache.size to query_cache.max_size Rename cfg parameter query_cache.size to query_cache.max_size Mar 24, 2023
@rschu1ze rschu1ze marked this pull request as ready for review March 24, 2023 12:53
@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Mar 25, 2023

ClickHouse Stateless Tests (aarch64):

  • 02668_parse_datetime_in_joda_syntax: fixed in "master"

@alexey-milovidov alexey-milovidov merged commit b6892f5 into master Mar 26, 2023
@alexey-milovidov alexey-milovidov deleted the rs/qc-better-cfg-name branch March 26, 2023 21:36
@alexey-milovidov alexey-milovidov self-assigned this Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants