Don't use the query cache for queries with totals/extremes#48717
Closed
Don't use the query cache for queries with totals/extremes#48717
Conversation
Member
|
@rschu1ze if we will store the full result in the query cache, and replay it, the problem should not exist: #48500 (comment) |
alexey-milovidov
approved these changes
Apr 12, 2023
|
totals/extremes results can't be cached? I use them a lot |
Member
Author
|
Real fix (wip) in the spirit of #48717 (comment) --> #48853. Let's close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48677
It is not obvious how pipelines with totals or extremes can be handled with the query cache. Perhaps it's an edge case, so disable it for now.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Disable usage of the query cache for queries with totals or extremes.