This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Include solvers to avoid include path dependency.#1329
Merged
Conversation
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 2, 2024
matz-e
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Jul 2, 2024
In BlueBrain/nmodl#1329, solver includes for MOD file generation are included in the NMODL binary. This PR removes remaining CMake glue, as well as outdated code removed in BlueBrain/nmodl#964. Sitting on top of PR #1305.
This comment has been minimized.
This comment has been minimized.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 2, 2024
This comment has been minimized.
This comment has been minimized.
Similar to #1305, include the solver headers in variables in a C++ header, and include them in the code generated for the MOD files. This should allow to substitute different NMODL binaries in NEURON builds without confusion as to which solver headers are going to be included in the MOD file compilation.
7a72d9a to
a6b19d5
Compare
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 2, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 2, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 2, 2024
This comment has been minimized.
This comment has been minimized.
Also only use it for testing, and use targets where appropriate.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
matz-e
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Jul 4, 2024
In BlueBrain/nmodl#1329, solver includes for MOD file generation are included in the NMODL binary. This PR removes remaining CMake glue, as well as outdated code removed in BlueBrain/nmodl#964. Sitting on top of PR #1305.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 178 178
Lines 13458 13459 +1
=======================================
+ Hits 11490 11491 +1
Misses 1968 1968 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 4, 2024
Collaborator
|
Logfiles from GitLab pipeline #220283 (:white_check_mark:) have been uploaded here! Status and direct links: |
pramodk
reviewed
Jul 4, 2024
alkino
reviewed
Jul 4, 2024
pramodk
approved these changes
Jul 5, 2024
pramodk
reviewed
Jul 5, 2024
matz-e
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Jul 5, 2024
In BlueBrain/nmodl#1329, solver includes for MOD file generation are included in the NMODL binary. This PR removes remaining CMake glue, as well as outdated code removed in BlueBrain/nmodl#964. Sitting on top of PR #1305.
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Jul 8, 2024
* In BlueBrain/nmodl#1329, solver includes for MOD file generation are included in the NMODL binary. This PR removes remaining CMake glue, as well as outdated code removed in BlueBrain/nmodl#964. Sitting on top of PR #1305. * NEURON copies the Eigen headers into the installation prefix
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
Similar to BlueBrain/nmodl#1305, include the solver headers in variables in a C++ header, and include them in the code generated for the MOD files. This should allow to substitute different NMODL binaries in NEURON builds without confusion as to which solver headers are going to be included in the MOD file compilation. NMODL Repo SHA: BlueBrain/nmodl@7910146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #1305, include the solver headers in variables in a C++
header, and include them in the code generated for the MOD files. This
should allow to substitute different NMODL binaries in NEURON builds
without confusion as to which solver headers are going to be included in
the MOD file compilation.
Tested in neuronsimulator/nrn#2953
CI_BRANCHES:NEURON_BRANCH=nmodl-include-header-cleanup