Remove NMODL include directory dependency.#2953
Merged
Merged
Conversation
|
✔️ 04b42ec -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
✔️ e073aa9 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bbae067 to
964c33c
Compare
|
✔️ 964c33c -> Azure artifacts URL |
|
✔️ fe54996 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2953 +/- ##
==========================================
- Coverage 67.26% 67.26% -0.01%
==========================================
Files 571 571
Lines 104877 104873 -4
==========================================
- Hits 70550 70545 -5
- Misses 34327 34328 +1 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
fe54996 to
8c3ba45
Compare
This comment has been minimized.
This comment has been minimized.
|
✔️ 8c3ba45 -> Azure artifacts URL |
In BlueBrain/nmodl#1329, solver includes for MOD file generation are included in the NMODL binary. This PR removes remaining CMake glue, as well as outdated code removed in BlueBrain/nmodl#964. Sitting on top of PR #1305.
Eigen CMake is really not made to be added internally.
8c3ba45 to
e1d03b2
Compare
This comment has been minimized.
This comment has been minimized.
|
✔️ 8be69ce -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
pramodk
reviewed
Jul 8, 2024
pramodk
left a comment
Member
There was a problem hiding this comment.
One question/suggestion otherwise LGTM!
|
✔️ 76d747c -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
|
✔️ cb0f21c -> Azure artifacts URL |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In BlueBrain/nmodl#1329, solver includes for MOD file generation are included in the NMODL binary. This PR removes remaining CMake glue, as well as outdated code removed in BlueBrain/nmodl#964. Sitting on top of #2952.
Closes #2952.
CI_BRANCHES:NMODL_BRANCH=master