Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Remove Eigen::PartialPivLU and replace it with Crout LU decomposition#964

Merged
kotsaloscv merged 28 commits into
masterfrom
kotsalos/eigen_removal
Oct 24, 2022
Merged

Remove Eigen::PartialPivLU and replace it with Crout LU decomposition#964
kotsaloscv merged 28 commits into
masterfrom
kotsalos/eigen_removal

Conversation

@kotsaloscv

@kotsaloscv kotsaloscv commented Oct 11, 2022 •
edited by iomaganaris
Loading

Copy link
Copy Markdown
Contributor

Remove Eigen::PartialPivLU and replace it with Crout LU decomposition

closes #943

@kotsaloscv kotsaloscv requested review from olupton and pramodk October 11, 2022 14:43
@kotsaloscv kotsaloscv self-assigned this Oct 11, 2022
Christos Kotsalos added 8 commits October 11, 2022 16:52
@bbpbuildbot

bbpbuildbot commented Oct 11, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #78256 (:no_entry:) have been uploaded here!

Status and direct links:

@bbpbuildbot

bbpbuildbot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #78297 (:no_entry:) have been uploaded here!

Status and direct links:

@bbpbuildbot

bbpbuildbot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #78316 (:no_entry:) have been uploaded here!

Status and direct links:

@bbpbuildbot

bbpbuildbot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #78372 (:no_entry:) have been uploaded here!

Status and direct links:

@bbpbuildbot

bbpbuildbot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #78409 (:white_check_mark:) have been uploaded here!

Status and direct links:

pramodk
pramodk approved these changes Oct 17, 2022
View reviewed changes

@pramodk pramodk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodk

pramodk commented Oct 17, 2022

Copy link
Copy Markdown
Contributor 
PYTHONPATH=/home/vsts/work/1/s/nrn/build/lib::/home/vsts/work/1/s/nrn/build/lib/python MODLUNIT=/home/vsts/work/1/s/nrn/build/share/mod2c/nrnunits.lib /home/vsts/work/1/s/nrn/build/bin/nmodl x86_64/corenrn/mod2c/hh.mod -o x86_64/corenrn/mod2c/ host --c passes --inline sympy --analytic
Segmentation fault (core dumped)
make[3]: *** [/home/vsts/work/1/s/nrn/build/share/coreneuron/nrnivmodl_core_makefile:253: x86_64/corenrn/mod2c/halfgap.cpp] Error 139
make[3]: *** Waiting for unfinished jobs....

Is something worth looking for segfault?

@bbpbuildbot

bbpbuildbot commented Oct 17, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #79240 (:white_check_mark:) have been uploaded here!

Status and direct links:

@kotsaloscv kotsaloscv closed this Oct 17, 2022
@kotsaloscv kotsaloscv reopened this Oct 17, 2022
@bbpbuildbot

bbpbuildbot commented Oct 17, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #79268 (:white_check_mark:) have been uploaded here!

Status and direct links:

@iomaganaris iomaganaris reopened this Oct 17, 2022
@bbpbuildbot

bbpbuildbot commented Oct 17, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #79364 (:white_check_mark:) have been uploaded here!

Status and direct links:

@kotsaloscv kotsaloscv marked this pull request as draft October 19, 2022 13:35
@bbpbuildbot

bbpbuildbot commented Oct 19, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #79688 (:no_entry:) have been uploaded here!

Status and direct links:

@kotsaloscv kotsaloscv marked this pull request as ready for review October 20, 2022 07:10
@bbpbuildbot

bbpbuildbot commented Oct 20, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #79757 (:no_entry:) have been uploaded here!

Status and direct links:

@kotsaloscv kotsaloscv closed this Oct 21, 2022
@kotsaloscv kotsaloscv reopened this Oct 21, 2022
@bbpbuildbot

bbpbuildbot commented Oct 21, 2022

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #80165 (:white_check_mark:) have been uploaded here!

Status and direct links:

@kotsaloscv

kotsaloscv commented Oct 24, 2022

Copy link
Copy Markdown
Contributor Author

@pramodk shall we merge it?
I have added the error checking.
All the tests are passing, see as well: BlueBrain/CoreNeuron#871

pramodk
pramodk approved these changes Oct 24, 2022
View reviewed changes

@pramodk pramodk left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good to go! (as squash & merge)

@kotsaloscv kotsaloscv merged commit 888f287 into master Oct 24, 2022
@kotsaloscv kotsaloscv deleted the kotsalos/eigen_removal branch October 24, 2022 10:53
matz-e added a commit to neuronsimulator/nrn that referenced this pull request Jul 2, 2024
@matz-e
Remove NMODL include directory dependency.
04b42ec 
In BlueBrain/nmodl#1329, solver includes for MOD file generation are
included in the NMODL binary. This PR removes remaining CMake glue, as
well as outdated code removed in BlueBrain/nmodl#964. Sitting on top of
PR #1305.
@matz-e matz-e mentioned this pull request Jul 2, 2024
Merged
matz-e added a commit to neuronsimulator/nrn that referenced this pull request Jul 4, 2024
@matz-e
Remove NMODL include directory dependency.
fc0d5fd 
In BlueBrain/nmodl#1329, solver includes for MOD file generation are
included in the NMODL binary. This PR removes remaining CMake glue, as
well as outdated code removed in BlueBrain/nmodl#964. Sitting on top of
PR #1305.
matz-e added a commit to neuronsimulator/nrn that referenced this pull request Jul 5, 2024
@matz-e
Remove NMODL include directory dependency.
1fc5786 
In BlueBrain/nmodl#1329, solver includes for MOD file generation are
included in the NMODL binary. This PR removes remaining CMake glue, as
well as outdated code removed in BlueBrain/nmodl#964. Sitting on top of
PR #1305.
pramodk pushed a commit to neuronsimulator/nrn that referenced this pull request Jul 8, 2024
@matz-e
Remove NMODL include directory dependency. (#2953)
c2b939c 
* In BlueBrain/nmodl#1329, solver includes for MOD file generation are
included in the NMODL binary. This PR removes remaining CMake glue, as
well as outdated code removed in BlueBrain/nmodl#964. Sitting on top of
PR #1305.
* NEURON copies the Eigen headers into the installation prefix
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Removal of Eigen's PartialPivLU and replacement with Crout LU decompo…
93b8cb2 
…sition (BlueBrain/nmodl#964)

NMODL Repo SHA: BlueBrain/nmodl@888f287
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@olupton olupton olupton approved these changes
@iomaganaris iomaganaris iomaganaris left review comments
@pramodk pramodk pramodk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kotsaloscv kotsaloscv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove dependency with Eigen (and use internal Crout solver implementation instead)

5 participants

@kotsaloscv @bbpbuildbot @iomaganaris @pramodk @olupton