This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Make nmodl independent of nmodl.#1305
Merged
Merged
Conversation
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1305 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 178 178
Lines 13415 13415
=======================================
Hits 11476 11476
Misses 1939 1939 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 7, 2024
This comment has been minimized.
This comment has been minimized.
matz-e
approved these changes
Jun 10, 2024
pramodk
approved these changes
Jun 10, 2024
pramodk
left a comment
Contributor
There was a problem hiding this comment.
Question is more for clarification, LGTM!
The executable from the Python library.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 10, 2024
Collaborator
|
Logfiles from GitLab pipeline #215997 (:white_check_mark:) have been uploaded here! Status and direct links: |
matz-e
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Jul 1, 2024
With `ode.py` integrated into the C++ code, I don't think we need the `PYTHONPATH` handling any longer.
matz-e
added a commit
that referenced
this pull request
Jul 2, 2024
Similar to #1305, include the solver headers in variables in a C++ header, and include them in the code generated for the MOD files. This should allow to substitute different NMODL binaries in NEURON builds without confusion as to which solver headers are going to be included in the MOD file compilation.
This was referenced Jul 2, 2024
matz-e
added a commit
that referenced
this pull request
Jul 2, 2024
Similar to #1305, include the solver headers in variables in a C++ header, and include them in the code generated for the MOD files. This should allow to substitute different NMODL binaries in NEURON builds without confusion as to which solver headers are going to be included in the MOD file compilation.
matz-e
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Jul 4, 2024
With `ode.py` integrated into the C++ code, I don't think we need the `PYTHONPATH` handling any longer.
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Jul 5, 2024
With `ode.py` integrated into the C++ code, don't need the `PYTHONPATH` handling any longer.
matz-e
added a commit
that referenced
this pull request
Jul 5, 2024
Similar to #1305, include the solver headers in variables in a C++ header, and include them in the code generated for the MOD files. This should allow to substitute different NMODL binaries in NEURON builds without confusion as to which solver headers are going to be included in the MOD file compilation.
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
The executable from the Python library. NMODL Repo SHA: BlueBrain/nmodl@c5ecfea
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
Similar to BlueBrain/nmodl#1305, include the solver headers in variables in a C++ header, and include them in the code generated for the MOD files. This should allow to substitute different NMODL binaries in NEURON builds without confusion as to which solver headers are going to be included in the MOD file compilation. NMODL Repo SHA: BlueBrain/nmodl@7910146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The executable from the Python library.