Skip to content

[ML][Pipelines] Fix NodeOutput bool test in download#27587

Merged
wangchao1230 merged 1 commit intoAzure:mainfrom
zhengfeiwang:fix-output-bool-test-in-download
Nov 18, 2022
Merged

[ML][Pipelines] Fix NodeOutput bool test in download#27587
wangchao1230 merged 1 commit intoAzure:mainfrom
zhengfeiwang:fix-output-bool-test-in-download

Conversation

@zhengfeiwang
Copy link
Copy Markdown
Member

@zhengfeiwang zhengfeiwang commented Nov 18, 2022

Description

Use is not None to check if a NodeOutput object is None to avoid banned bool test for expression.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@wangchao1230 wangchao1230 merged commit ad15a4e into Azure:main Nov 18, 2022
@zhengfeiwang zhengfeiwang deleted the fix-output-bool-test-in-download branch November 18, 2022 05:30
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Dec 1, 2022
…into add_multiapi_combiner

* 'main' of https://github.com/Azure/azure-sdk-for-python: (557 commits)
  [ML] Fix job.services transformation for pipeline jobs (Azure#27422)
  fix: explicitly check using is not None (Azure#27587)
  [Pipeline] Convert mldesigner primitive annotation to Input type (Azure#27539)
  code and test (Azure#27586)
  [ML][Pipelines] Enable Pipelines owned skip tests (Azure#27540)
  Update Language-Settings.ps1 (Azure#27531)
  ci: enable test_dump_distribution (Azure#27535)
  code and test (Azure#27553)
  Increment package version after release of azure-ai-textanalytics (Azure#27583)
  fix doc for autodetect default language (Azure#27577)
  [Tables] Regen with latest autorest (Azure#27205)
  [TA] regen on latest spec (Azure#27486)
  Enforce Package name approval for preview release (Azure#27573)
  Remove manual conda test stage (Azure#27576)
  [Test Proxy] Add error response when starting test proxy (Azure#26155)
  Update test_registry.py (Azure#27574)
  Explicitly disable storage blob public access for workspace templates (Azure#27396)
  Use the new audience field (Azure#27571)
  Sync eng/common directory with azure-sdk-tools for PR 4628 (Azure#27455)
  fix non-pipeline-input with annotation and default value (Azure#27492)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants