Skip to content

Enforce Package name approval for preview release#27573

Merged
praveenkuttappan merged 2 commits intoAzure:mainfrom
praveenkuttappan:enable_preview_release_check
Nov 17, 2022
Merged

Enforce Package name approval for preview release#27573
praveenkuttappan merged 2 commits intoAzure:mainfrom
praveenkuttappan:enable_preview_release_check

Conversation

@praveenkuttappan
Copy link
Copy Markdown
Member

APIView returns 202 is package is not approved for preview release. Package must be approved (basic approval like package name) in APIView to release a package as preview if it was never approved or released as GA before.

@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Nov 17, 2022
@praveenkuttappan praveenkuttappan self-assigned this Nov 17, 2022
Copy link
Copy Markdown
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple minor nits but LGTM

Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
@praveenkuttappan
Copy link
Copy Markdown
Member Author

@scbedd FYI. Python release for a preview version will start failing once this PR is merged if that package was never GAed before and require approval from architects. I will be sending out an email but it's a heads up in case if anyone reaches out about this error directly.

@praveenkuttappan praveenkuttappan merged commit cd54fcf into Azure:main Nov 17, 2022
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Dec 1, 2022
…into add_multiapi_combiner

* 'main' of https://github.com/Azure/azure-sdk-for-python: (557 commits)
  [ML] Fix job.services transformation for pipeline jobs (Azure#27422)
  fix: explicitly check using is not None (Azure#27587)
  [Pipeline] Convert mldesigner primitive annotation to Input type (Azure#27539)
  code and test (Azure#27586)
  [ML][Pipelines] Enable Pipelines owned skip tests (Azure#27540)
  Update Language-Settings.ps1 (Azure#27531)
  ci: enable test_dump_distribution (Azure#27535)
  code and test (Azure#27553)
  Increment package version after release of azure-ai-textanalytics (Azure#27583)
  fix doc for autodetect default language (Azure#27577)
  [Tables] Regen with latest autorest (Azure#27205)
  [TA] regen on latest spec (Azure#27486)
  Enforce Package name approval for preview release (Azure#27573)
  Remove manual conda test stage (Azure#27576)
  [Test Proxy] Add error response when starting test proxy (Azure#26155)
  Update test_registry.py (Azure#27574)
  Explicitly disable storage blob public access for workspace templates (Azure#27396)
  Use the new audience field (Azure#27571)
  Sync eng/common directory with azure-sdk-tools for PR 4628 (Azure#27455)
  fix non-pipeline-input with annotation and default value (Azure#27492)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants