Skip to content

[Pipeline] Convert mldesigner primitive annotation to Input type#27539

Merged
wangchao1230 merged 3 commits intoAzure:mainfrom
lalala123123:zhrua/convert_annotation
Nov 18, 2022
Merged

[Pipeline] Convert mldesigner primitive annotation to Input type#27539
wangchao1230 merged 3 commits intoAzure:mainfrom
lalala123123:zhrua/convert_annotation

Conversation

@lalala123123
Copy link
Copy Markdown
Member

@lalala123123 lalala123123 commented Nov 16, 2022 •
edited
Loading

Description

from mldesigner._input_output import String, Boolean, Number, Integer

@dsl.pipeline()
    def pipeline_with_primitive_annotations(
            str1: String,
            str2: String(optional=False, description="string annotation"),
            boolean1: Boolean,
            boolean2: Boolean(optional=False, description="bool annotation"),
            number1: Number,
            number2: Number(optional=False, description="number annotation", min=-1.0, max=1.0),
            integer1: Integer,
            integer2: Integer(optional=False, description="int annotation", min=-1, max=1),
            enum: String(enum=SampleEnum),
    ):
        component = component_with_primitive_annotations(
            str1=str1,
            str2=str2,
            boolean1=boolean1,
            boolean2=boolean2,
            number1=number1,
            number2=number2,
            integer1=integer1,
            integer2=integer2,
            enum=enum
        )
        return component.outputs

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@lalala123123 lalala123123 added the ML-Pipelines AreaPath label Nov 16, 2022
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Nov 16, 2022

API change check

API changes are not detected in this pull request.

@lalala123123 lalala123123 reopened this Nov 17, 2022
@wangchao1230 wangchao1230 enabled auto-merge (squash) November 17, 2022 09:50
@wangchao1230 wangchao1230 merged commit fcdafbc into Azure:main Nov 18, 2022
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Dec 1, 2022
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
9784d28 
…into add_multiapi_combiner

* 'main' of https://github.com/Azure/azure-sdk-for-python: (557 commits)
  [ML] Fix job.services transformation for pipeline jobs (Azure#27422)
  fix: explicitly check using is not None (Azure#27587)
  [Pipeline] Convert mldesigner primitive annotation to Input type (Azure#27539)
  code and test (Azure#27586)
  [ML][Pipelines] Enable Pipelines owned skip tests (Azure#27540)
  Update Language-Settings.ps1 (Azure#27531)
  ci: enable test_dump_distribution (Azure#27535)
  code and test (Azure#27553)
  Increment package version after release of azure-ai-textanalytics (Azure#27583)
  fix doc for autodetect default language (Azure#27577)
  [Tables] Regen with latest autorest (Azure#27205)
  [TA] regen on latest spec (Azure#27486)
  Enforce Package name approval for preview release (Azure#27573)
  Remove manual conda test stage (Azure#27576)
  [Test Proxy] Add error response when starting test proxy (Azure#26155)
  Update test_registry.py (Azure#27574)
  Explicitly disable storage blob public access for workspace templates (Azure#27396)
  Use the new audience field (Azure#27571)
  Sync eng/common directory with azure-sdk-tools for PR 4628 (Azure#27455)
  fix non-pipeline-input with annotation and default value (Azure#27492)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1

@singankit singankit Awaiting requested review from singankit

@diondrapeck diondrapeck Awaiting requested review from diondrapeck

@luigiw luigiw Awaiting requested review from luigiw

@harneetvirk harneetvirk Awaiting requested review from harneetvirk

@kdestin kdestin Awaiting requested review from kdestin

@MilesHolland MilesHolland Awaiting requested review from MilesHolland

@needuv needuv Awaiting requested review from needuv

@nthandeMS nthandeMS Awaiting requested review from nthandeMS

+1 more reviewer

@0mza987 0mza987 0mza987 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ML-Pipelines AreaPath

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lalala123123 @azure-sdk @0mza987 @wangchao1230