Closed
Conversation
Contributor
Author
|
Probably will need RTL and min assets generated. |
Contributor
Author
|
We're also moving the "Add Contact Form" button directly into the TinyMCE Toolbar. |
Contributor
Author
|
This was developed originally at https://github.com/Automattic/gm2016-grunion-editor -- so it has the full history there. |
Contributor
|
I would like to dramatically overhaul the styles here. I'm not sure that's doable in time for this release considering all the things we're wrangling in settings land. Can we plan for this to be in the following release to give us a little time to polish it? |
Contributor
Author
|
@MichaelArestad There is no target for merge, so no rush. |
Member
|
Fixes #7063 |
Publicize: fix notice when $pages is set to false.
This fixes an issue when we were showing the wrong text on personal plan. It also re-writes the logic to show the content to make it more readable. It also fixes an issue where we were not showing the `set up` button on professional plans if scan was not enabled for some reason.
When SEO plugins like Yoast SEO or All in one SEO are installed on Jetpack site, SEO Tools should stop modifying the meta tags.
…wpcom-1495046933 WPCOM REST API: Do Not Return Early From /comments POST
Contact Form: Send all emails through wrapper to ensure consistency
:thinking_face:
Sync: Fix `jetpack_sync_add_term` and `jetpack_sync_save_term` being sent together
…t sync action args (#7437)
Removes a pre-WP 4.7 hack needed to handle a core bug with the REST API on sites using a particular permalink structure.
* Updates unit test to account for new core behavior * Updates unit test to account for new core behavior * Updates unit test to account for new core behavior * Updates unit test to account for new core behavior
Remove shiv for REST API
Update version to next alpha and packages
Protect: Stop showing multisite network activation warning on beta installs
#7455) * Jetpack Sync: Adding name of importer to sync details for activity log * Moving get importer functionality to its own method * Moving get importer functionality to its own method * Adding dummy change to see if it somehow resolves Travis issue * Removing whitespace added to see if pushing again somehow impacted Travis issue.
See 69-gh-wp-calypso The REST API settings endpoint includes a property `jetpack_relatedposts_enabled`, which is true if the Related Posts plugin will display related posts. The value from this endpoint is incorrect, however, when a site has not modified their settings. This is because the `Jetpack_RelatedPosts` plugin defaults the setting to be enabled if it is not set. This change modifies the endpoint to use the same logic: if the setting is not set, it will default to reporting `jetpack_relatedposts_enabled` as true. Some sites (VIP and Jetpack) default this setting to `false` instead, but the way this is accomplished is that when the plugin is loaded by `wp-content/mu-plugins/related-posts.php`, it actively changes the option to `false`. Since that loader should still be used by the REST API, that should mean that such sites will continue to have `jetpack_relatedposts_enabled` reported correctly. This commit syncs r159322-wpcom.
…m-1500391197 REST API: Settings: fix `jetpack_relatedposts_enabled`
Contributor
Author
|
The diff to implement this on wpcom is at D6457 |
eliorivero
reviewed
Jul 19, 2017
| '[contact-field label="' . __( 'Message', 'jetpack' ) . '" type="textarea" /]', | ||
| 'labels' => array( | ||
| 'submit_button_text' => __( 'Submit', 'jetpack' ), | ||
| 'required_field_text' => apply_filters( 'jetpack_required_field_text', __( '(required)', 'jetpack' ) ), |
Contributor
There was a problem hiding this comment.
This needs a phpdoc so it's collected by our inline doc parser.
Contributor
Author
|
The prior mentioned phabricator diff has been updated with the latest changes. |
Contributor
Author
|
Well, rebasing made this messier than expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #2065
This is currently just adding the overrides -- I'm intentionally not removing the old legacy code yet, to ease the transition on any users that prefer the old method. They can just disable the new include line, and the old way will be back again.
Props @MichaelArestad @azaozz and @georgestephanis for building this at the 2016 a8c GM.
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes: