Skip to content

Updates unit test to account for new core behavior#7473

Merged
dereksmart merged 4 commits intomasterfrom
fix/7471
Jul 17, 2017
Merged

Updates unit test to account for new core behavior#7473
dereksmart merged 4 commits intomasterfrom
fix/7471

Conversation

@kraftbj
Copy link
Copy Markdown
Contributor

@kraftbj kraftbj commented Jul 17, 2017

Fixes #7471

Updates the test to account for the new core behavior. The test's intent is to ensure we aren't mishandling stuff, so it makes sense to update it along with core's new way of handling shortcode args.

@kraftbj kraftbj added [Feature] Forms Unit Tests [Pri] BLOCKER [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Jul 17, 2017
@kraftbj kraftbj requested a review from dereksmart July 17, 2017 19:00
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kraft!

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jul 17, 2017
@dereksmart dereksmart merged commit d4481bd into master Jul 17, 2017
@dereksmart dereksmart deleted the fix/7471 branch July 17, 2017 20:30
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Forms [Pri] BLOCKER Unit Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit Tests: Contact form now fails in WP trunk

2 participants