Skip to content

WPCOM REST API: Do Not Return Early From /comments POST#7197

Merged
zinigor merged 1 commit intomasterfrom
sync/timmydcrawford/r156341-wpcom-1495046933
May 26, 2017
Merged

WPCOM REST API: Do Not Return Early From /comments POST#7197
zinigor merged 1 commit intomasterfrom
sync/timmydcrawford/r156341-wpcom-1495046933

Conversation

@timmyc
Copy link
Copy Markdown
Contributor

@timmyc timmyc commented May 17, 2017

The logic in the /sites/s/comments POST endpoint was returning early 672-gh-io

This commit syncs r156341-wpcom.

The logic in the /sites/s/comments POST endpoint was returning early and subsequently was preventing Akisment logic from processing comments marked as spam properly.  672-gh-io, and https://[private link] for historical context

This commit syncs r156341-wpcom.
@jeherve jeherve added [Status] Tested on WP.com [Type] Dotcom Merge [Feature] WPCOM API [Pri] BLOCKER [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels May 17, 2017
@timmyc
Copy link
Copy Markdown
Contributor Author

timmyc commented May 18, 2017

so many labels 😮

@jeherve jeherve modified the milestone: 5.0 May 26, 2017
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐑

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 26, 2017
@zinigor zinigor merged commit 7235ee4 into master May 26, 2017
@zinigor zinigor removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 26, 2017
@eliorivero eliorivero deleted the sync/timmydcrawford/r156341-wpcom-1495046933 branch May 26, 2017 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants