Skip to content

Sync: Fix jetpack_sync_add_term and jetpack_sync_save_term being sent together#7429

Merged
lezama merged 1 commit intomasterfrom
update/sync-add-term
Jul 6, 2017
Merged

Sync: Fix jetpack_sync_add_term and jetpack_sync_save_term being sent together#7429
lezama merged 1 commit intomasterfrom
update/sync-add-term

Conversation

@lezama
Copy link
Copy Markdown
Contributor

@lezama lezama commented Jul 5, 2017

Changes proposed in this Pull Request:

  • Don't send two actions when saving a term.

Previous to this change we were syncing two actions: jetpack_sync_add_term and jetpack_sync_save_term

Testing instructions:

  • Add a new term
  • Check that only jetpack_sync_add_term gets sent.

@lezama lezama self-assigned this Jul 5, 2017
@lezama lezama requested review from gititon and roccotripaldi July 5, 2017 21:58
Copy link
Copy Markdown
Contributor

@roccotripaldi roccotripaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Copy Markdown
Contributor

@gititon gititon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lezama lezama merged commit 6b82ff5 into master Jul 6, 2017
@lezama lezama deleted the update/sync-add-term branch July 6, 2017 17:01
@kraftbj kraftbj removed the [Status] Needs Review This PR is ready for review. label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants