Skip to content

Instant Search: Add support in glance and performance sections#15043

Merged
jsnmoon merged 7 commits intoadd/search-planfrom
update/glance-and-performance-for-search-plan
Mar 20, 2020
Merged

Instant Search: Add support in glance and performance sections#15043
jsnmoon merged 7 commits intoadd/search-planfrom
update/glance-and-performance-for-search-plan

Conversation

@jsnmoon
Copy link
Copy Markdown
Contributor

@jsnmoon jsnmoon commented Mar 19, 2020 •
edited
Loading

Changes proposed in this Pull Request:

  1. Updates the Search section of the At-a-Glance page with an updated copy.
    a) Activating Search will also activate Instant Search if the site has a Search plan.
    b) Customers are encouraged to upgrade to the Jetpack Search plan instead of the Premium plan. (Not sure why we were recommending them to upgrade to a Premium plan for search; search is only included in the Professional plan.)
    c) If on a Search plan, they will be linked to the Jetpack Search settings in the Customizer instead of Widget panel.

Screen Shot 2020-03-18 at 3 43 16 PM

Screen Shot 2020-03-18 at 3 43 05 PM

  1. Updates the Search section in the Performance settings page. Also reorders sections so that the Search section is now at the top.
    a) Adds another toggle for enabling Instant Search. This toggle is only interactable for sites with a Search plan.
    b) Sites with either business or search plans are prompted to enable the search module.
    c) If Instant Search is toggled on, we include a link to the Jetpack Search section of the Customizer. If not, we link to the widget panel of the Customizer.

Screen Shot 2020-03-19 at 2 36 53 PM

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Yes, but this PR merges into a feature branch.

Testing instructions:

  1. Apply these changes to your site.

For a site without an active Jetpack plan subscription:

  1. Navigate to the At-a-Glance page (/wp-admin/admin.php?page=jetpack#/dashboard). You should be prompted to purchase a Jetpack Search plan via an upgrade link.
  2. Navigate to the Performance tab in the settings page (/wp-admin/admin.php?page=jetpack#/performance). You should be prompted to purchase a Search plan here as well.

For a site with a Jetpack Professional plan:

  1. Navigate to the At-a-Glance page. There should be a toggle to enable/disable Jetpack Search as well as a link to add a Jetpack Search widget via the Customizer.
  2. Navigate to the Performance tab in the settings page. You should be able to toggle Jetpack Search on and off.

For a site with a Jetpack Search plan (it's not possible to test these steps quite yet):

  1. Navigate to the At-a-Glance page. There should be a toggle to enable/disable Jetpack Instant Search as well as a link to the Jetpack Search section of the Customizer.
  2. Navigate to the Performance tab in the settings page. Enabling Jetpack Search should automatically enable Instant Search as well.

Proposed changelog entry for your changes:

  • None. This PR merged into a feature branch.

@jsnmoon jsnmoon self-assigned this Mar 19, 2020
@jsnmoon jsnmoon force-pushed the update/glance-and-performance-for-search-plan branch from 89f039a to 025c824 Compare March 19, 2020 21:31
@jsnmoon jsnmoon force-pushed the update/glance-and-performance-for-search-plan branch from 025c824 to 8c2475f Compare March 19, 2020 21:36
@jsnmoon jsnmoon added [Status] Needs Team Review Obsolete. Use Needs Review instead. Plans labels Mar 19, 2020
@jsnmoon jsnmoon requested review from a team, AnnaMag, DavidRothstein, gibrown and keoshi March 19, 2020 22:28
@jsnmoon jsnmoon marked this pull request as ready for review March 19, 2020 22:28
@jsnmoon jsnmoon requested a review from a team March 19, 2020 22:29
@jsnmoon jsnmoon added Instant Search [Feature] Search For all things related to Search labels Mar 19, 2020
keoshi
keoshi approved these changes Mar 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This set of changes is incredible, @jsnmoon ! Amazing work.

Left a couple of comments on strings, but nothing that blocks this getting merged.

Now, I just want to know how to enable a Search plan so I can test the final bits. :)

Not sure why we were recommending them to upgrade to a Premium plan for search; search is only included in the Professional plan.

Hah! How come no one never noticed this before?

@gibrown
Copy link
Copy Markdown
Member

gibrown commented Mar 20, 2020

Added the search plan to the dev menu to make testing easier.

Screen Shot 2020-03-20 at 10 55 45 AM

@gibrown gibrown mentioned this pull request Mar 20, 2020
Closed
gibrown
gibrown approved these changes Mar 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@gibrown gibrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An upgrade to Pro message is appearing when the current plan is Search or when it is on a Free plan:

Screen Shot 2020-03-20 at 11 12 48 AM

Probably what we want is when they are on the Pro plan we should point them at the Search plan (also on the at-a-glance page).

We could punt these to a separate PR though as a lot of functionality is implemented here. Could also punt some word-smithing.

keoshi
keoshi reviewed Mar 20, 2020
View reviewed changes
@jsnmoon @keoshi
Improve copy in Performance settings
e1776c6 
Co-Authored-By: Filipe Varela <keoshi@keoshi.com>
@jsnmoon jsnmoon merged commit adfc3b1 into add/search-plan Mar 20, 2020
@jsnmoon jsnmoon deleted the update/glance-and-performance-for-search-plan branch March 20, 2020 21:57
@jsnmoon jsnmoon removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Mar 20, 2020
gibrown added a commit that referenced this pull request Mar 30, 2020
@gibrown
Search: Add search plan to dashboard (#15153)
a5ec8c3 
* Search: Add Search plan to wp-admin Plans/My-Plans pages (#15011)
* Add Instant Search feature gate
* Add Jetpack Search to the Plans page
* Instant Search: Add support in glance and performance sections (#15043)
* Search: Add instant search auto config (#15026)
* Significant refactoring of Plans pages, especially for Backups
* Update the copy for search module. (#15123)
* Search: Add search plan to my-plans page (#15095)
* Search: Add pricing and tier information to Plans page (#15125)
* Search: Fix search plan detection (#15156)
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
Admin Page: place Photon section before VideoPress
a862d70 
Follow-up from #15043.

It seems Photon may be more valuable and important for most Jetpack site owners.
@jeherve jeherve mentioned this pull request Mar 31, 2020
Merged
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
Admin Page: place Photon section before VideoPress (#15212)
802497c 
Follow-up from #15043.

It seems Photon may be more valuable and important for most Jetpack site owners.
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
[not verified] Admin Page: place Photon section before VideoPress (#1…
c14d618 
…5212)

Follow-up from #15043.

It seems Photon may be more valuable and important for most Jetpack site owners.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keoshi keoshi keoshi approved these changes

@gibrown gibrown gibrown approved these changes

@AnnaMag AnnaMag Awaiting requested review from AnnaMag

@DavidRothstein DavidRothstein Awaiting requested review from DavidRothstein

Assignees

@jsnmoon jsnmoon

Labels

[Feature] Search For all things related to Search Plans

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsnmoon @gibrown @keoshi @matticbot