Skip to content

Admin Page: place Photon section before VideoPress#15212

Merged
jeherve merged 1 commit intomasterfrom
fix/photon-videopress-order
Mar 31, 2020
Merged

Admin Page: place Photon section before VideoPress#15212
jeherve merged 1 commit intomasterfrom
fix/photon-videopress-order

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Mar 31, 2020

Follow-up from #15043.

Changes proposed in this Pull Request:

@jsnmoon @gibrown Could I have your opinion on this? This was changed in #15043, but it seems to me that Photon may be more valuable and important for most Jetpack site owners. Search can remain at the top of the section, which I think was the intended change, but do we need to change the order of the sections below?

Testing instructions:

  • Go to Jetpack > Settings > Performance
  • The cards should follow this order:
    1. Search
    2. Site Accelerator
    3. Videos
  • They previously were set as Search - Videos - Site Accelerator

Proposed changelog entry for your changes:

  • N/A

@jeherve
Admin Page: place Photon section before VideoPress
a862d70 
Follow-up from #15043.

It seems Photon may be more valuable and important for most Jetpack site owners.
@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Cherry-Pick labels Mar 31, 2020
@jeherve jeherve added this to the 8.4 milestone Mar 31, 2020
@jeherve jeherve requested review from a team, gibrown and jsnmoon March 31, 2020 11:18
@jeherve jeherve self-assigned this Mar 31, 2020
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Mar 31, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against a862d70

dereksmart
dereksmart approved these changes Mar 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 31, 2020
gibrown
gibrown approved these changes Mar 31, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@gibrown gibrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeherve jeherve merged commit 802497c into master Mar 31, 2020
@jeherve jeherve deleted the fix/photon-videopress-order branch March 31, 2020 17:02
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 31, 2020
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
[not verified] Admin Page: place Photon section before VideoPress (#1…
c14d618 
…5212)

Follow-up from #15043.

It seems Photon may be more valuable and important for most Jetpack site owners.
@jeherve
Copy link
Copy Markdown
Member Author

jeherve commented Mar 31, 2020

Cherry-picked to branch-8.4 in c14d618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gibrown gibrown gibrown approved these changes

@dereksmart dereksmart dereksmart approved these changes

@jsnmoon jsnmoon Awaiting requested review from jsnmoon

+1 more reviewer

@brbrr brbrr brbrr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeherve jeherve

Labels

Admin Page React-powered dashboard under the Jetpack menu Bug When a feature is broken and / or not performing as intended

Projects

None yet

Milestone

8.4

Development

Successfully merging this pull request may close these issues.

6 participants

@jeherve @jetpackbot @gibrown @brbrr @dereksmart @matticbot