Search: Add search plan to my-plans page#15095
Merged
gibrown merged 5 commits intoadd/search-planfrom Mar 26, 2020
Merged
Conversation
Contributor
|
I believe the existing pattern (for JP Backup) is to reuse the plan icon, which I've added on Automattic/wp-calypso#40382 |
jsnmoon
suggested changes
Mar 25, 2020
Contributor
jsnmoon
left a comment
There was a problem hiding this comment.
I don't think this is working as intended. My site has a Jetpack Free plan and a Jetpack Search product purchased via the Checkout flow via Calypso.
With this change, the Instant Search card is missing:
When I manually set my plan to Search, I get the following:
31ebfbc to
cf17758
Compare
jsnmoon
approved these changes
Mar 25, 2020
Contributor
jsnmoon
left a comment
There was a problem hiding this comment.
I just pushed a commit that fixes the bugs mentioned in my previous review. Please double-check my changes before merging!
jsnmoon
reviewed
Mar 26, 2020
gibrown
added a commit
that referenced
this pull request
Mar 30, 2020
* Search: Add Search plan to wp-admin Plans/My-Plans pages (#15011) * Add Instant Search feature gate * Add Jetpack Search to the Plans page * Instant Search: Add support in glance and performance sections (#15043) * Search: Add instant search auto config (#15026) * Significant refactoring of Plans pages, especially for Backups * Update the copy for search module. (#15123) * Search: Add search plan to my-plans page (#15095) * Search: Add pricing and tier information to Plans page (#15125) * Search: Fix search plan detection (#15156)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
To test:
Fixes #15070