Skip to content

Search: Add Search plan to wp-admin Plans page#15011

Merged
jsnmoon merged 2 commits intoadd/search-planfrom
add/search-plan-to-plans-page
Mar 17, 2020
Merged

Search: Add Search plan to wp-admin Plans page#15011
jsnmoon merged 2 commits intoadd/search-planfrom
add/search-plan-to-plans-page

Conversation

@jsnmoon
Copy link
Copy Markdown
Contributor

@jsnmoon jsnmoon commented Mar 17, 2020

Screen Shot 2020-03-16 at 7 14 06 PM

Changes proposed in this Pull Request:

  • Adds Jetpack Search to wp-admin's plans page (/wp-admin/admin.php?page=jetpack#/plans).
  • This feature is gated behind a constant JETPACK_SEARCH_PROTOTYPE in PHP.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Yes, this will add the Jetpack Search plan to the wp-admin plans page.
  • We're merging this into a feature branch, however.

Testing instructions:

  1. Apply the change from this branch.
  2. Add define( "JETPACK_SEARCH_PROTOTYPE", true ); to your wp-config.php. If using Jetpack's Docker development environment, you can create a file at /docker/mu-plugins/instant-search.php and add the define there.
  3. Navigate to the wp-admin Jetpack Plans page (/wp-admin/admin.php?page=jetpack#/plans).
  4. Ensure that the Search plan renders as expected.

Proposed changelog entry for your changes:

  • None. This is being merged into a feature branch.

@jsnmoon jsnmoon added Admin Page React-powered dashboard under the Jetpack menu [Feature] Search For all things related to Search Plans Instant Search [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Mar 17, 2020
@jsnmoon jsnmoon added this to the InstantSearchLaunch milestone Mar 17, 2020
@jsnmoon jsnmoon requested review from a team, gibrown and keoshi March 17, 2020 01:19
@jsnmoon jsnmoon self-assigned this Mar 17, 2020
@jsnmoon
Copy link
Copy Markdown
Contributor Author

jsnmoon commented Mar 17, 2020

@keoshi, I propose we collaborate on polishing and tweaking wp-admin pages for Instant Search in the add/search-plan branch. What do you think? 😃

@keoshi
Copy link
Copy Markdown
Contributor

keoshi commented Mar 17, 2020

Let's do it @jsnmoon !

keoshi
keoshi approved these changes Mar 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works beautifully!

I can confirm the Search block is behind that flag and I can't see it unless I add the constant:

image

Once the constant is added, the plans appear side by side and both boxes grow vertically to balance out the UI:

image

One thing to note here is that the header for the existing single product block changes depending if pre or post-purchase, so that will have to be tackled in order to get a consistent look. That will be tackled in a separate PR.

@keoshi keoshi mentioned this pull request Mar 17, 2020
Merged
@keoshi
Copy link
Copy Markdown
Contributor

keoshi commented Mar 17, 2020

One thing to note here is that the header for the existing single product block changes depending if pre or post-purchase, so that will have to be tackled in order to get a consistent look. That will be tackled in a separate PR.

Created a PR for this here: #15016

@jsnmoon jsnmoon merged commit 756dcd9 into add/search-plan Mar 17, 2020
@jsnmoon jsnmoon deleted the add/search-plan-to-plans-page branch March 17, 2020 19:16
@jsnmoon jsnmoon removed [Status] Needs Changelog [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Mar 17, 2020
gibrown added a commit that referenced this pull request Mar 30, 2020
@gibrown
Search: Add search plan to dashboard (#15153)
a5ec8c3 
* Search: Add Search plan to wp-admin Plans/My-Plans pages (#15011)
* Add Instant Search feature gate
* Add Jetpack Search to the Plans page
* Instant Search: Add support in glance and performance sections (#15043)
* Search: Add instant search auto config (#15026)
* Significant refactoring of Plans pages, especially for Backups
* Update the copy for search module. (#15123)
* Search: Add search plan to my-plans page (#15095)
* Search: Add pricing and tier information to Plans page (#15125)
* Search: Fix search plan detection (#15156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keoshi keoshi keoshi approved these changes

@gibrown gibrown Awaiting requested review from gibrown

Assignees

@jsnmoon jsnmoon

Labels

Admin Page React-powered dashboard under the Jetpack menu [Feature] Search For all things related to Search Plans

Projects

None yet

Milestone

Instant Search: Launch

Development

Successfully merging this pull request may close these issues.

3 participants

@jsnmoon @keoshi @matticbot