QA ticket grab bag by raymondjacobson · Pull Request #10514 · AudiusProject/apps

raymondjacobson · 2024-11-23T04:02:46Z

Description

Bunch of misc fixes on web.
Can be reviewed commit by commit.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Local web vs. staging

gitguardian · 2024-11-23T04:02:49Z

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
11080651	Triggered	Generic High Entropy Secret	`70546b4`	packages/web/src/services/env/env.prod.ts	View secret
11080650	Triggered	Generic High Entropy Secret	`70546b4`	packages/web/src/services/env/env.stage.ts	View secret
11080651	Triggered	Generic High Entropy Secret	`70546b4`	packages/mobile/src/env/env.prod.ts	View secret
11080650	Triggered	Generic High Entropy Secret	`70546b4`	packages/mobile/src/env/env.stage.ts	View secret
2111319	Triggered	Generic High Entropy Secret	`70546b4`	packages/web/src/services/env/env.prod.ts	View secret
2111320	Triggered	Generic High Entropy Secret	`70546b4`	packages/web/src/services/env/env.stage.ts	View secret
2111320	Triggered	Generic High Entropy Secret	`70546b4`	packages/mobile/src/env/env.stage.ts	View secret
2111319	Triggered	Generic High Entropy Secret	`70546b4`	packages/mobile/src/env/env.prod.ts	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

dylanjeffers

Great! I noticed the repost images are a bit far from the repost name + n reposters text on desktop track tiles, mind handling that if it hasn't already?

dylanjeffers · 2024-11-23T04:04:20Z

packages/harmony/src/components/text/Text.tsx

        WebkitBoxOrient: 'vertical'
-      })
+      }),
+      unicodeBidi: 'isolate'


dylanjeffers · 2024-11-23T04:08:32Z

packages/web/src/components/comments/CommentForm.tsx

+      // Reset input text when the location changes
+      setMessageId((prev) => prev + 1)
+    }
+  }, [previousLocation, location])


Can we add a hasLocationChanged var so this use effect doesn't trigger as often?

dylanjeffers · 2024-11-23T04:09:03Z

packages/web/src/components/track/TrackTileMetrics.tsx

  return (
    <VanityMetric ellipses to={url} onClick={handleClick}>
      <IconMessage size='s' color='subdued' />
-      {comment_count > 0 ? formatCount(comment_count) : 'Leave a comment'}


Nice, technically not the exact spec but I like this more anyway

nah design asked for this

Sg, I'll follow up with them on Monday just to confirm changing the Figma design then

https://www.figma.com/design/gGVAGoOfp1hcpHCvmHKRUh/%F0%9F%92%AC-Commenting?node-id=2760-55145&node-type=frame&m=dev

it's already reflected & there was convo in the ticket

audius-infra · 2024-11-23T04:17:30Z

Preview this change https://demo.audius.co/rj-qa-1835

audius-infra · 2024-11-23T04:35:18Z

Preview this change https://demo.audius.co/rj-qa-1835

raymondjacobson · 2024-11-23T05:05:29Z

Great! I noticed the repost images are a bit far from the repost name + n reposters text on desktop track tiles, mind handling that if it hasn't already?

I think we're good

some display names have a trailing space after i've noticed. we should probably trim that, but bigger convo

[34d450f] QA ticket grab bag (#10514) Raymond Jacobson [ccb7082] [PAY-3607] Migrate explore tracks to sdk (#10509) Reed [bb6828e] [PAY-3503] Update no longer can message user UI (#10505) Reed [80c700e] Revert "[C-5342] Upgrade react-native to 0.75 (#10301)" (#10497) Andrew Mendelsohn [bb06fba] Fix sidebar playlists account sync (#10495) Isaac Solo [047598a] [C-5405] Update upload flow with file replace (#10494) Kyle Shanks [e1bc4ca] [QA-1842] Fix web date picker time default (#10491) Isaac Solo [2fdfd7b] Remove PREFER_HIGHER_PATCH_FOR_PRIMARY/SECONDARIES feature flags (#10480) Reed [2736806] [C-5410] Add ReplaceTrackConfirmation modal (#10489) Kyle Shanks [8c52795] [C-5408] Move delete track action to overflow menu (#10487) Kyle Shanks [4cfea48] [C-5395 & C-5396] Upgrade to amplitude v2 and enable session replay (#10463) JD Francis [d6f43a6] Fix watchQueueAutoplay test (#10488) Andrew Mendelsohn [4d15579] [C-5430] Add feature flag for track audio replace (#10482) Kyle Shanks [7820db8] Remove AI_ATTRIBUTION feature flag (#10476) Reed [09ec89b] [C-5404] Add FileReplaceContainer component to web (#10462) Kyle Shanks [14756ed] Remove DISCOVERY_TIP_REACTIONS feature flag (#10479) Reed [92eed35] Remove DEVELOPER_APPS_PAGE feature flag (#10477) Reed [f242d87] Remove SDK_DISCOVERY_NODE_SELECTOR feature flag (#10474) Reed [ec135ba] Remove LAZY_USERBANK_CREATION_ENABLED feature flag (#10473) Reed [bc4452e] Remove misc feature flags (#10478) Reed [980e2b0] Remove RELATED_ARTISTS_ON_PROFILE_ENABLED feature flag (#10475) Reed [4d76fbe] Remove PODCAST_CONTROL_UPDATES_ENABLED feature flag (#10471) Reed [914b46b] Remove EARLY_ACCESS feature flag (#10469) Reed [5d0a9ed] Remove RATE_CTA_ENABLED feature flag (#10467) Reed [61e9ddf] Remove OFFLINE_MODE_RELEASE feature flag (#10466) Reed [85fb740] [C-5403, C-5411] Add Upload icon to harmony (#10459) Kyle Shanks [d51cc3c] [QA-1840] Fix Offline Mode errors (#10460) Andrew Mendelsohn [9a0603f] [C-5416] Basic guest checkout behind feature flag (#10447) Isaac Solo [38e007c] [C-5417] Update track audio replace for sdk change (#10458) Kyle Shanks [8455921] Remove TIPPING_ENABLED feature flag (#10457) Reed [0403468] Remove SOLANA_LISTEN_ENABLED feature flag (#10456) Reed [a93a826] Fix track edit sdk issues (#10450) Sebastian Klingler [5484dac] [QA-1827] Fix queuing short profile lineups issue (#10451) Randy Schott [c4ef1e0] Fix bad useEffects calls in PremiumContentPurchaseDrawer (#10454) Randy Schott

This reverts commit 34d450f.

raymondjacobson added 7 commits November 22, 2024 18:48

[QA-1835] Fix comment timestamp not playing track

81837d9

[QA-1828] Fix alignment of playing indicator

50c99d0

[QA-1848] Remove crown while loading

067f71b

[QA-1830] Fix unicode chars backwards overflowing

c68889f

[QA-1834] Fix broken comment edit

9f36a66

Fix amplitude

70546b4

[QA-1829] Fix missing share and small tile layout

797411f

pull-request-size bot added the size/M label Nov 23, 2024

raymondjacobson requested review from DejayJD and dylanjeffers November 23, 2024 04:02

dylanjeffers approved these changes Nov 23, 2024

View reviewed changes

Address comment

5219b7f

raymondjacobson merged commit 34d450f into main Nov 23, 2024

raymondjacobson deleted the rj-qa-1835 branch November 23, 2024 05:05

dylanjeffers added a commit that referenced this pull request Nov 27, 2024

Revert "QA ticket grab bag (#10514)"

c6c6a2c

This reverts commit 34d450f.

Conversation

raymondjacobson commented Nov 23, 2024

Description

How Has This Been Tested?

Uh oh!

gitguardian bot commented Nov 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Uh oh!

dylanjeffers left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Nov 23, 2024

Uh oh!

audius-infra commented Nov 23, 2024

Uh oh!

raymondjacobson commented Nov 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gitguardian bot commented Nov 23, 2024 •

edited

Loading