Skip to content

Fix sidebar playlists account sync#10495

Merged
isaacsolo merged 7 commits intomainfrom
is-fix-sidebar-playlists
Nov 21, 2024
Merged

Fix sidebar playlists account sync#10495
isaacsolo merged 7 commits intomainfrom
is-fix-sidebar-playlists

Conversation

@isaacsolo
Copy link

@isaacsolo isaacsolo commented Nov 20, 2024 •
edited
Loading

Description

When moving fetchAccountAsync from web common to common in #10447, I typed User incorrectly, dropping playlists.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Confirmed sidebar playlists now load correctly.

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a208846

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@isaacsolo isaacsolo requested a review from schottra November 20, 2024 20:20
@audius-infra
Copy link
Collaborator

audius-infra commented Nov 20, 2024

Preview this change https://demo.audius.co/is-fix-sidebar-playlists

schottra
schottra reviewed Nov 20, 2024
View reviewed changes
packages/common/src/store/account/sagas.ts Outdated
])
)

const { playlists: collections, ...user } = accountUser
Copy link
Contributor

@schottra schottra Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update fetchAccountLocalAsync and anything else that calls into this function to pass the right shape.

schottra
schottra reviewed Nov 20, 2024
View reviewed changes
packages/common/src/store/account/sagas.ts Outdated
collections: [],
userId: accountUser.user_id,
collections,
orderedPlaylists: []
Copy link
Contributor

@schottra schottra Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is actually used? We can probably just remove it from the type expected by the local storage function and stop passing empty here all the time?

@pull-request-size pull-request-size bot added size/L and removed size/S labels Nov 20, 2024
@audius-infra
Copy link
Collaborator

audius-infra commented Nov 20, 2024

Preview this change https://demo.audius.co/is-fix-sidebar-playlists

@audius-infra
Copy link
Collaborator

audius-infra commented Nov 20, 2024

Preview this change https://demo.audius.co/is-fix-sidebar-playlists

schottra
schottra reviewed Nov 20, 2024
View reviewed changes
packages/common/src/store/account/sagas.ts Outdated
yield put(
cacheActions.add(Kind.USERS, [
{ id: account.user_id, uid: 'USER_ACCOUNT', metadata: account }
{ id: accountUser.user_id, uid: 'USER_ACCOUNT', metadata: account }
Copy link
Contributor

@schottra schottra Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh oops, I think this should be metadata: accountUser!

Copy link
Contributor

@schottra schottra Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also since this is now using the audiusQuery saga fetch stuff, I don't think we actually have to do this caching in this function. It will already be there.
This is actually what was causing the null entries.

@audius-infra
Copy link
Collaborator

audius-infra commented Nov 21, 2024

Preview this change https://demo.audius.co/is-fix-sidebar-playlists

@isaacsolo isaacsolo enabled auto-merge (squash) November 21, 2024 19:49
@audius-infra
Copy link
Collaborator

audius-infra commented Nov 21, 2024

Preview this change https://demo.audius.co/is-fix-sidebar-playlists

@isaacsolo isaacsolo merged commit bb06fba into main Nov 21, 2024
@isaacsolo isaacsolo deleted the is-fix-sidebar-playlists branch November 21, 2024 20:25
audius-infra pushed a commit that referenced this pull request Nov 23, 2024
Audius Client (Web and Mobile) v1.5.110
218d5a3 
[34d450f] QA ticket grab bag (#10514) Raymond Jacobson
[ccb7082] [PAY-3607] Migrate explore tracks to sdk (#10509) Reed
[bb6828e] [PAY-3503] Update no longer can message user UI (#10505) Reed
[80c700e] Revert "[C-5342] Upgrade react-native to 0.75 (#10301)" (#10497) Andrew Mendelsohn
[bb06fba] Fix sidebar playlists account sync (#10495) Isaac Solo
[047598a] [C-5405] Update upload flow with file replace (#10494) Kyle Shanks
[e1bc4ca] [QA-1842] Fix web date picker time default (#10491) Isaac Solo
[2fdfd7b] Remove PREFER_HIGHER_PATCH_FOR_PRIMARY/SECONDARIES feature flags (#10480) Reed
[2736806] [C-5410] Add ReplaceTrackConfirmation modal (#10489) Kyle Shanks
[8c52795] [C-5408] Move delete track action to overflow menu (#10487) Kyle Shanks
[4cfea48] [C-5395 & C-5396] Upgrade to amplitude v2 and enable session replay (#10463) JD Francis
[d6f43a6] Fix watchQueueAutoplay test (#10488) Andrew Mendelsohn
[4d15579] [C-5430] Add feature flag for track audio replace (#10482) Kyle Shanks
[7820db8] Remove AI_ATTRIBUTION feature flag (#10476) Reed
[09ec89b] [C-5404] Add FileReplaceContainer component to web (#10462) Kyle Shanks
[14756ed] Remove DISCOVERY_TIP_REACTIONS feature flag (#10479) Reed
[92eed35] Remove DEVELOPER_APPS_PAGE feature flag (#10477) Reed
[f242d87] Remove SDK_DISCOVERY_NODE_SELECTOR feature flag (#10474) Reed
[ec135ba] Remove LAZY_USERBANK_CREATION_ENABLED feature flag (#10473) Reed
[bc4452e] Remove misc feature flags (#10478) Reed
[980e2b0] Remove RELATED_ARTISTS_ON_PROFILE_ENABLED feature flag (#10475) Reed
[4d76fbe] Remove PODCAST_CONTROL_UPDATES_ENABLED feature flag (#10471) Reed
[914b46b] Remove EARLY_ACCESS feature flag (#10469) Reed
[5d0a9ed] Remove RATE_CTA_ENABLED feature flag (#10467) Reed
[61e9ddf] Remove OFFLINE_MODE_RELEASE feature flag (#10466) Reed
[85fb740] [C-5403, C-5411] Add Upload icon to harmony (#10459) Kyle Shanks
[d51cc3c] [QA-1840] Fix Offline Mode errors (#10460) Andrew Mendelsohn
[9a0603f] [C-5416] Basic guest checkout behind feature flag (#10447) Isaac Solo
[38e007c] [C-5417] Update track audio replace for sdk change (#10458) Kyle Shanks
[8455921] Remove TIPPING_ENABLED feature flag (#10457) Reed
[0403468] Remove SOLANA_LISTEN_ENABLED feature flag (#10456) Reed
[a93a826] Fix track edit sdk issues (#10450) Sebastian Klingler
[5484dac] [QA-1827] Fix queuing short profile lineups issue (#10451) Randy Schott
[c4ef1e0] Fix bad useEffects calls in PremiumContentPurchaseDrawer (#10454) Randy Schott
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondjacobson raymondjacobson raymondjacobson approved these changes

+2 more reviewers

@schottra schottra schottra left review comments

@amendelsohn amendelsohn amendelsohn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@isaacsolo @audius-infra @schottra @amendelsohn @raymondjacobson