Skip to content

Revert "[C-5342] Upgrade react-native to 0.75 (#10301)"#10497

Merged
amendelsohn merged 9 commits intomainfrom
am-revert-rn-75
Nov 22, 2024
Merged

Revert "[C-5342] Upgrade react-native to 0.75 (#10301)"#10497
amendelsohn merged 9 commits intomainfrom
am-revert-rn-75

Conversation

@amendelsohn
Copy link
Contributor

@amendelsohn amendelsohn commented Nov 20, 2024

This reverts commit ae6d881.

Description

PAY-3610

RN upgrade made us slower 😢
Reverted and cleaned up some deps

How Has This Been Tested?

Navigation on press is feeling way snappier already 🎉

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: c2d3733

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/am-revert-rn-75

@amendelsohn amendelsohn requested review from a team and Kyle-Shanks and removed request for a team November 20, 2024 22:38
Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why CI is failing?

@amendelsohn
Copy link
Contributor Author

any idea why CI is failing?

Not yet. Looking into it

Copy link
Contributor

@dharit-tan dharit-tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also want to revert this if we;re dowgrading react?
#10315

@dharit-tan
Copy link
Contributor

do we also want to revert this if we;re dowgrading react? #10315

nvm i guess those changes are largely reverted in this PR.

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/am-revert-rn-75

@gitguardian
Copy link

gitguardian bot commented Nov 21, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
3249666 Triggered Generic Password 60d4091 packages/commands/src/utils.mjs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@alch/alchemy-web3@1.4.6 network 0 6.65 MB brian-alchemy
npm/@amplitude/analytics-browser@2.11.9 Transitive: network +9 4.01 MB sdk.dev
npm/@amplitude/node@1.9.2 network +4 590 kB kevinpagtakhan
npm/@amplitude/plugin-session-replay-browser@1.8.2 Transitive: network +14 13.8 MB sdk.dev
npm/@amplitude/react-native@2.17.2 None 0 187 kB hao.yu
npm/@apollo/client@3.3.7 environment, network Transitive: eval +1 3.3 MB apollo-bot
npm/@apollo/usage-reporting-protobuf@4.1.1 None 0 1.02 MB apollo-bot
npm/@apollo/utils.dropunuseddefinitions@2.0.1 None 0 6.58 kB apollo-bot
npm/@apollo/utils.keyvaluecache@2.1.1 None 0 34.1 kB apollo-bot
npm/@apollo/utils.logger@2.0.1 None 0 7.64 kB apollo-bot
npm/@apollo/utils.printwithreducedwhitespace@2.0.1 None 0 6.83 kB apollo-bot
npm/@apollo/utils.removealiases@2.0.1 None 0 4.95 kB apollo-bot
npm/@apollo/utils.sortast@2.0.1 None 0 8.93 kB apollo-bot
npm/@apollo/utils.stripsensitiveliterals@2.0.1 None 0 9.43 kB apollo-bot
npm/@apollo/utils.usagereporting@2.1.0 None 0 26.7 kB apollo-bot
npm/@assemblyscript/loader@0.9.4 None 0 33.1 kB assemblyscript
npm/@audius/fetch-nft@0.2.7 network +2 1.12 MB marcus_audius
npm/@audius/hedgehog@3.0.0-alpha.1 Transitive: filesystem +4 403 kB audius-project
npm/@babel/cli@7.7.0 Transitive: environment, filesystem, shell, unsafe +8 1.79 MB nicolo-ribaudo
npm/@babel/code-frame@7.23.5 None 0 23.3 kB nicolo-ribaudo
npm/@babel/compat-data@7.23.5 None 0 64.6 kB nicolo-ribaudo
npm/@babel/generator@7.23.6 None 0 492 kB nicolo-ribaudo
npm/@babel/helper-annotate-as-pure@7.22.5 None 0 4.02 kB nicolo-ribaudo
npm/@babel/helper-compilation-targets@7.23.6 Transitive: environment, filesystem, unsafe +7 1.75 MB nicolo-ribaudo
npm/@babel/helper-environment-visitor@7.22.20 None 0 6.56 kB nicolo-ribaudo
npm/@babel/helper-function-name@7.23.0 None 0 21.6 kB nicolo-ribaudo
npm/@babel/helper-hoist-variables@7.22.5 None 0 7.03 kB nicolo-ribaudo
npm/@babel/helper-module-imports@7.22.15 None 0 54.4 kB nicolo-ribaudo
npm/@babel/helper-plugin-utils@7.22.5 None 0 11.9 kB nicolo-ribaudo
npm/@babel/helper-split-export-declaration@7.22.6 None 0 10.7 kB nicolo-ribaudo
npm/@babel/helper-validator-identifier@7.22.20 None 0 49.1 kB nicolo-ribaudo
npm/@babel/helper-validator-option@7.23.5 None 0 11.7 kB nicolo-ribaudo
npm/@babel/highlight@7.23.4 None 0 18.4 kB nicolo-ribaudo
npm/@babel/parser@7.24.1 None 0 1.88 MB nicolo-ribaudo
npm/@babel/plugin-proposal-class-static-block@7.21.0 Transitive: environment, filesystem, unsafe +13 2 MB nicolo-ribaudo
npm/@babel/plugin-transform-react-jsx@7.21.0 Transitive: environment, filesystem, unsafe +8 1.78 MB nicolo-ribaudo
npm/@babel/plugin-transform-runtime@7.18.2 unsafe Transitive: environment, filesystem +7 1.71 MB nicolo-ribaudo
npm/@babel/preset-env@7.22.15 environment Transitive: filesystem, unsafe +90 3.73 MB nicolo-ribaudo
npm/@babel/preset-typescript@7.22.15 Transitive: environment, filesystem, unsafe +16 2.19 MB nicolo-ribaudo
npm/@babel/register@7.7.0 environment, filesystem Transitive: unsafe +7 1.7 MB nicolo-ribaudo
npm/@babel/runtime@7.18.3 None 0 201 kB nicolo-ribaudo
npm/@babel/template@7.22.15 None 0 69.2 kB nicolo-ribaudo
npm/@babel/traverse@7.23.6 None 0 610 kB nicolo-ribaudo
npm/@babel/types@7.23.6 environment 0 2.41 MB nicolo-ribaudo
npm/@certusone/wormhole-sdk@0.1.1 filesystem Transitive: environment +2 15.2 MB evan-gray
npm/@changesets/cli@2.27.1 environment, filesystem, shell +27 1.43 MB changesets-release-bot
npm/@cloudflare/kv-asset-handler@0.3.1 None +1 126 kB wrangler-publisher
npm/@coinbase/cbpay-js@1.2.0 None 0 172 kB lachiet
npm/@coinflowlabs/react@3.1.5 network +2 222 kB meeder-coinflow
npm/@coral-xyz/anchor@0.29.0 environment, filesystem, network +2 2.21 MB acheroncrypto
npm/@coral-xyz/borsh@0.29.0 None 0 22.2 kB acheroncrypto
npm/@elastic/elasticsearch@8.1.0 Transitive: network +2 2.46 MB delvedor
npm/@emotion/babel-plugin@11.11.0 environment +3 283 kB emotion-release-bot
npm/@emotion/babel-preset-css-prop@11.11.0 environment Transitive: filesystem, unsafe +9 1.73 MB emotion-release-bot
npm/@emotion/css@11.11.2 environment +6 516 kB emotion-release-bot
npm/@emotion/eslint-plugin@11.11.0 environment 0 101 kB emotion-release-bot
npm/@emotion/is-prop-valid@1.2.1 environment 0 29.1 kB emotion-release-bot
npm/@emotion/memoize@0.8.1 environment 0 4.29 kB emotion-release-bot
npm/@emotion/native@11.11.0 environment +1 75.3 kB emotion-release-bot
npm/@emotion/react@11.11.1 environment +7 845 kB emotion-release-bot
npm/@emotion/server@11.11.0 environment +2 77.7 kB emotion-release-bot
npm/@emotion/styled@11.11.0 environment +4 271 kB emotion-release-bot
npm/@emotion/stylis@0.8.5 environment 0 105 kB emotion-release-bot
npm/@emotion/unitless@0.8.1 environment 0 7.05 kB emotion-release-bot
npm/@esbuild-plugins/node-globals-polyfill@0.2.3 None 0 105 kB xmorse
npm/@escape.tech/mookme@2.4.1 environment, filesystem, shell +4 271 kB steffthestunt
npm/@eslint-community/regexpp@4.10.0 None 0 431 kB eslint-community-bot
npm/@ethereumjs/common@3.2.0 None +2 585 kB holgerd77
npm/@ethereumjs/tx@4.2.0 None 0 275 kB holgerd77
npm/@ethersproject/abi@5.4.1 None 0 495 kB ricmoo
npm/@ethersproject/abstract-provider@5.4.1 None 0 59.6 kB ricmoo
npm/@ethersproject/abstract-signer@5.4.1 None 0 82.3 kB ricmoo
npm/@ethersproject/address@5.4.0 None 0 32.9 kB ricmoo
npm/@ethersproject/base64@5.4.0 None 0 11.2 kB ricmoo
npm/@ethersproject/basex@5.4.0 None 0 30.1 kB ricmoo
npm/@ethersproject/contracts@5.4.1 None 0 245 kB ricmoo
npm/@ethersproject/hash@5.4.0 None 0 120 kB ricmoo
npm/@ethersproject/hdnode@5.4.0 None 0 80.4 kB ricmoo
npm/@ethersproject/json-wallets@5.4.0 None 0 124 kB ricmoo
npm/@ethersproject/networks@5.4.2 None 0 41.1 kB ricmoo
npm/@ethersproject/pbkdf2@5.4.0 None 0 17.2 kB ricmoo
npm/@ethersproject/properties@5.4.1 None 0 31 kB ricmoo
npm/@ethersproject/providers@5.4.5 network +2 1.19 MB ricmoo
npm/@ethersproject/random@5.4.0 None 0 16.6 kB ricmoo
npm/@ethersproject/rlp@5.4.0 None 0 29.5 kB ricmoo
npm/@ethersproject/signing-key@5.4.0 None 0 243 kB ricmoo
npm/@ethersproject/transactions@5.4.0 None 0 89.5 kB ricmoo
npm/@ethersproject/units@5.4.0 None 0 20.2 kB ricmoo
npm/@ethersproject/wallet@5.4.0 None 0 55.2 kB ricmoo
npm/@ethersproject/web@5.4.0 network 0 113 kB ricmoo
npm/@ethersproject/wordlists@5.4.0 None 0 392 kB ricmoo
npm/@fingerprintjs/fingerprintjs-pro-server-api@4.1.2 network 0 184 kB fp-pro
npm/@fingerprintjs/fingerprintjs-pro@3.5.6 eval, network +1 852 kB surgie
npm/@google/model-viewer@3.3.0 network 0 30.9 MB google-wombot
npm/@gorhom/bottom-sheet@4.6.4 None +1 1.43 MB gorhom
npm/@gorhom/portal@1.0.9 None 0 89.6 kB gorhom
npm/@graphql-tools/merge@8.4.2 None 0 100 kB ardatan
npm/@grpc/grpc-js@1.12.0 environment, filesystem, network 0 1.94 MB murgatroid99
npm/@grpc/proto-loader@0.7.13 filesystem Transitive: network +2 3.01 MB murgatroid99
npm/@hcaptcha/react-hcaptcha@0.3.6 None 0 30.8 kB brdlyptrs
npm/@humanwhocodes/config-array@0.11.13 None +1 110 kB nzakas
npm/@improbable-eng/grpc-web-node-http-transport@0.15.0 network 0 12.1 kB marcuslongmuir
npm/@improbable-eng/grpc-web@0.14.1 network 0 65.7 kB marcuslongmuir
npm/@ipld/dag-pb@2.1.18 None 0 236 kB npm-service-account-ipld
npm/@isaacs/cliui@8.0.2 None +6 171 kB isaacs
npm/alchemy-sdk@2.0.1 None 0 1.44 MB brian-alchemy
npm/prom-client@14.0.1 filesystem, network, unsafe 0 105 kB simenb

🚮 Removed packages: npm/@aragon/court@1.1.3, npm/@cloudflare/kv-asset-handler@0.0.12, npm/@openzeppelin/contracts-ethereum-package@2.5.0, npm/@openzeppelin/test-helpers@0.5.5, npm/@openzeppelin/truffle-upgrades@1.17.0, npm/@openzeppelin/upgrades@2.8.0, npm/@truffle/hdwallet-provider@1.7.0, npm/@typescript-eslint/eslint-plugin@5.55.0, npm/@typescript-eslint/parser@5.55.0, npm/async@2.6.4, npm/babel-polyfill@6.26.0, npm/babel-preset-env@1.7.0, npm/babel-register@6.26.0, npm/bignumber.js@8.0.1

View full report↗︎

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/am-revert-rn-75

@amendelsohn amendelsohn merged commit 80c700e into main Nov 22, 2024
@amendelsohn amendelsohn deleted the am-revert-rn-75 branch November 22, 2024 01:51
raymondjacobson pushed a commit that referenced this pull request Nov 22, 2024
Co-authored-by: Dharit Tantiviramanond <dharit.tan@gmail.com>
audius-infra pushed a commit that referenced this pull request Nov 22, 2024
[80c700e] Revert "[C-5342] Upgrade react-native to 0.75 (#10301)" (#10497) Andrew Mendelsohn
[f5f7a1a] Add MRVR to MRI reporting plugin (#10470) Raymond Jacobson
audius-infra pushed a commit that referenced this pull request Nov 23, 2024
[34d450f] QA ticket grab bag (#10514) Raymond Jacobson
[ccb7082] [PAY-3607] Migrate explore tracks to sdk (#10509) Reed
[bb6828e] [PAY-3503] Update no longer can message user UI (#10505) Reed
[80c700e] Revert "[C-5342] Upgrade react-native to 0.75 (#10301)" (#10497) Andrew Mendelsohn
[bb06fba] Fix sidebar playlists account sync (#10495) Isaac Solo
[047598a] [C-5405] Update upload flow with file replace (#10494) Kyle Shanks
[e1bc4ca] [QA-1842] Fix web date picker time default (#10491) Isaac Solo
[2fdfd7b] Remove PREFER_HIGHER_PATCH_FOR_PRIMARY/SECONDARIES feature flags (#10480) Reed
[2736806] [C-5410] Add ReplaceTrackConfirmation modal (#10489) Kyle Shanks
[8c52795] [C-5408] Move delete track action to overflow menu (#10487) Kyle Shanks
[4cfea48] [C-5395 & C-5396] Upgrade to amplitude v2 and enable session replay (#10463) JD Francis
[d6f43a6] Fix watchQueueAutoplay test (#10488) Andrew Mendelsohn
[4d15579] [C-5430] Add feature flag for track audio replace (#10482) Kyle Shanks
[7820db8] Remove AI_ATTRIBUTION feature flag (#10476) Reed
[09ec89b] [C-5404] Add FileReplaceContainer component to web (#10462) Kyle Shanks
[14756ed] Remove DISCOVERY_TIP_REACTIONS feature flag (#10479) Reed
[92eed35] Remove DEVELOPER_APPS_PAGE feature flag (#10477) Reed
[f242d87] Remove SDK_DISCOVERY_NODE_SELECTOR feature flag (#10474) Reed
[ec135ba] Remove LAZY_USERBANK_CREATION_ENABLED feature flag (#10473) Reed
[bc4452e] Remove misc feature flags (#10478) Reed
[980e2b0] Remove RELATED_ARTISTS_ON_PROFILE_ENABLED feature flag (#10475) Reed
[4d76fbe] Remove PODCAST_CONTROL_UPDATES_ENABLED feature flag (#10471) Reed
[914b46b] Remove EARLY_ACCESS feature flag (#10469) Reed
[5d0a9ed] Remove RATE_CTA_ENABLED feature flag (#10467) Reed
[61e9ddf] Remove OFFLINE_MODE_RELEASE feature flag (#10466) Reed
[85fb740] [C-5403, C-5411] Add Upload icon to harmony (#10459) Kyle Shanks
[d51cc3c] [QA-1840] Fix Offline Mode errors (#10460) Andrew Mendelsohn
[9a0603f] [C-5416] Basic guest checkout behind feature flag (#10447) Isaac Solo
[38e007c] [C-5417] Update track audio replace for sdk change (#10458) Kyle Shanks
[8455921] Remove TIPPING_ENABLED feature flag (#10457) Reed
[0403468] Remove SOLANA_LISTEN_ENABLED feature flag (#10456) Reed
[a93a826] Fix track edit sdk issues (#10450) Sebastian Klingler
[5484dac] [QA-1827] Fix queuing short profile lineups issue (#10451) Randy Schott
[c4ef1e0] Fix bad useEffects calls in PremiumContentPurchaseDrawer (#10454) Randy Schott
dylanjeffers added a commit that referenced this pull request Nov 27, 2024
dylanjeffers added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants