[PAY-3503] Update no longer can message user UI#10505
Merged
dharit-tan merged 3 commits intomainfrom Nov 22, 2024
Merged
Conversation
|
Collaborator
|
Preview this change https://demo.audius.co/rt-chat-unavail |
audius-infra
pushed a commit
that referenced
this pull request
Nov 23, 2024
[34d450f] QA ticket grab bag (#10514) Raymond Jacobson [ccb7082] [PAY-3607] Migrate explore tracks to sdk (#10509) Reed [bb6828e] [PAY-3503] Update no longer can message user UI (#10505) Reed [80c700e] Revert "[C-5342] Upgrade react-native to 0.75 (#10301)" (#10497) Andrew Mendelsohn [bb06fba] Fix sidebar playlists account sync (#10495) Isaac Solo [047598a] [C-5405] Update upload flow with file replace (#10494) Kyle Shanks [e1bc4ca] [QA-1842] Fix web date picker time default (#10491) Isaac Solo [2fdfd7b] Remove PREFER_HIGHER_PATCH_FOR_PRIMARY/SECONDARIES feature flags (#10480) Reed [2736806] [C-5410] Add ReplaceTrackConfirmation modal (#10489) Kyle Shanks [8c52795] [C-5408] Move delete track action to overflow menu (#10487) Kyle Shanks [4cfea48] [C-5395 & C-5396] Upgrade to amplitude v2 and enable session replay (#10463) JD Francis [d6f43a6] Fix watchQueueAutoplay test (#10488) Andrew Mendelsohn [4d15579] [C-5430] Add feature flag for track audio replace (#10482) Kyle Shanks [7820db8] Remove AI_ATTRIBUTION feature flag (#10476) Reed [09ec89b] [C-5404] Add FileReplaceContainer component to web (#10462) Kyle Shanks [14756ed] Remove DISCOVERY_TIP_REACTIONS feature flag (#10479) Reed [92eed35] Remove DEVELOPER_APPS_PAGE feature flag (#10477) Reed [f242d87] Remove SDK_DISCOVERY_NODE_SELECTOR feature flag (#10474) Reed [ec135ba] Remove LAZY_USERBANK_CREATION_ENABLED feature flag (#10473) Reed [bc4452e] Remove misc feature flags (#10478) Reed [980e2b0] Remove RELATED_ARTISTS_ON_PROFILE_ENABLED feature flag (#10475) Reed [4d76fbe] Remove PODCAST_CONTROL_UPDATES_ENABLED feature flag (#10471) Reed [914b46b] Remove EARLY_ACCESS feature flag (#10469) Reed [5d0a9ed] Remove RATE_CTA_ENABLED feature flag (#10467) Reed [61e9ddf] Remove OFFLINE_MODE_RELEASE feature flag (#10466) Reed [85fb740] [C-5403, C-5411] Add Upload icon to harmony (#10459) Kyle Shanks [d51cc3c] [QA-1840] Fix Offline Mode errors (#10460) Andrew Mendelsohn [9a0603f] [C-5416] Basic guest checkout behind feature flag (#10447) Isaac Solo [38e007c] [C-5417] Update track audio replace for sdk change (#10458) Kyle Shanks [8455921] Remove TIPPING_ENABLED feature flag (#10457) Reed [0403468] Remove SOLANA_LISTEN_ENABLED feature flag (#10456) Reed [a93a826] Fix track edit sdk issues (#10450) Sebastian Klingler [5484dac] [QA-1827] Fix queuing short profile lineups issue (#10451) Randy Schott [c4ef1e0] Fix bad useEffects calls in PremiumContentPurchaseDrawer (#10454) Randy Schott
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were not seeing this "no longer can message this user" UI because we were not incorporating
recheck_permissionsin thegetCanCreateChatselector (note that thegetCanSendMessageselector falls back to this in most cases).The backend logic was correct and permissions requests were returning the correct values, but we weren't using them on the client.
Also added the
ChatPermissionAction.FOLLOWcases on client which is new after the permissions updates from message blasts project. Previously we only had "only users you follow can message you" case, the case of "users who follow you can message you" is new.Also modernized/harmonized these components a bit.
Note: something is wonky with
UserLinkalignment - difficult to use them inline with other text. I found that setting lineHeight to 0 made it good enough in some cases.. but this might warrant another look cc @dylanjeffers . I took a stab at trying to figure out the root problem inUserLinkit but couldn't figure it out. Afaict it's becauseUserLinkis wrapped in aPressableandFlexwhich have their own height, and I couldn't get them todisplay: inline.The badges are also misaligned on web. But what I have now is not a regression in alignment, it's just been this way.
How Has This Been Tested?
Tested locally on web stage + ios stage
Confirmed that when Reed+2 sends a message to dharit3, dharit3 now has permission to send to Reed+2 as well.