Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ACINQ/eclair
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.2-android
Choose a base ref
...
head repository: ACINQ/eclair
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.3-android
Choose a head ref
  • 15 commits
  • 80 files changed
  • 6 contributors

Commits on Jul 9, 2019

  1. Wrap all routes in toStrictEntity (#1032)

    * Wrap all routes in toStrictEntity
    araspitzu authored Jul 9, 2019
    Configuration menu
    Copy the full SHA
    5f4a2eb View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2019

  1. Back to development

    dpad85 committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    3479824 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. TLV improvements and full spec compatibility (#1069)

    This PR adds support for truncated integers as defined in the spec.
    The test vectors are updated to include all test vectors from rusty's spec PR.
    It also provides many changes to the tlv and tlv stream classes:
    
    - The tlv trait doesn't need a type field, the codec should handle that
    - A TLV stream should be scoped to a specific subtrait of tlv
    - Stream validation is done inside the codec instead of the tlv stream: it makes it more convenient for application layers to create tlv streams and manipulate them
    t-bast authored Jul 11, 2019
    Configuration menu
    Copy the full SHA
    1621e39 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2019

  1. Added a channel version to Commitments object (#1059)

    In a backward-compatible way, by using the fact that the first object of
    a legacy `Commitments` was a public key, starting from 0x02 or 0x03.
    pm47 authored Jul 12, 2019
    Configuration menu
    Copy the full SHA
    c1a7b4f View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2019

  1. Configuration menu
    Copy the full SHA
    62946a0 View commit details
    Browse the repository at this point in the history
  2. Replace traits by bitfield for ChannelVersion (#1073)

    We now store the channel version on a 8B bitfield prefixed by `0x01`
    pm47 authored Jul 15, 2019
    Configuration menu
    Copy the full SHA
    00df431 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2019

  1. Configuration menu
    Copy the full SHA
    3b30be9 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. Handle fulfill not acked upstream (#1079)

    When we want to fulfill an HTLC but the upstream peer is unresponsive, we must close the channel if we get too close to the HTLC timeout on their side.
    Otherwise we risk an on-chain race condition between our HTLC success transaction and their HTLC timeout transaction, which could result in a loss of funds.
    t-bast authored Jul 23, 2019
    Configuration menu
    Copy the full SHA
    189b11e View commit details
    Browse the repository at this point in the history
  2. Variable-length onion payloads (#976)

    Add support for variable-length onion payloads at the Sphinx (cryptographic) layer.
    This is currently unused as we keep using the legacy format by default (this will be changed in a later commit).
    This commit also refactors quite heavily the Sphinx file.
    t-bast authored Jul 23, 2019
    Configuration menu
    Copy the full SHA
    93d9369 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. Made using/storing/sending consistent (#1082)

    We know can now do `goto(STATE) using DATA storing() sending msg1 msg2`.
    pm47 authored Jul 24, 2019
    Configuration menu
    Copy the full SHA
    e62adf2 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Configurable transaction confirmation target (#1083)

    * Use feeEstimator in NodeParams, remove all calls to Globals.feeratePerKw
    
    * Introduce FeeConf object and config block for confirmation targets, remove unused 'smartfeeNBlocks'
    
    * Use a custom confirmation target for commitment transaction
    
    * Use a custom confirmation target for funding transaction
    
    * Use custom confirmation target for mutual close transaction
    
    * Use custom confirmation target for claim transactions
    
    * Add confirmation target block 144
    
    * Use block target = 12 as default for claim transactions
    araspitzu authored Jul 25, 2019
    Configuration menu
    Copy the full SHA
    131f50a View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2019

  1. Use correct cost comparison when evaluating candidate channels (#1090)

    * Use correct cost comparison when evaluating if the amount we're sending is within the range htlcMinimumMsat/htlcMaximumMsat of the candidate channel
    araspitzu authored Jul 26, 2019
    Configuration menu
    Copy the full SHA
    d88d376 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c43035b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    138d2a2 View commit details
    Browse the repository at this point in the history
  4. Release v0.3.3-android

    dpad85 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    7c34f52 View commit details
    Browse the repository at this point in the history
Loading