TLV improvements and full spec compatibility#1069
Merged
Conversation
TLV doesn't have an abstract `type` field anymore. This is scoped to the codec itself. TLV streams are now scoped to a specific namespace (subtrait of TLV).
9291da2 to
bfb58dd
Compare
It should be more readable now.
pm47
approved these changes
Jul 11, 2019
sstone
approved these changes
Jul 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for truncated integers as defined in the spec.
The test vectors are updated to include all test vectors from rusty's spec PR.
It also provides many changes to the tlv and tlv stream classes:
typefield, the codec should handle thattlvI'm starting a thread on
scodec's gitter to see if we can do something better than thetagfunction that encodes the tlv to extract the discriminator, if that yields something I'll update the PR.