Replace traits by bitfield for ChannelVersion#1073
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1073 +/- ##
=========================================
+ Coverage 82.5% 82.6% +0.09%
=========================================
Files 99 99
Lines 7592 7595 +3
Branches 300 293 -7
=========================================
+ Hits 6264 6274 +10
+ Misses 1328 1321 -7
|
sstone
reviewed
Jul 15, 2019
|
|
||
| sealed trait ChannelVersion | ||
| case class ChannelVersion(bits: BitVector) { | ||
| require(bits.size == 4 * 8, "channel version takes 4 bytes") |
Member
There was a problem hiding this comment.
Size requirement is hardcoded in 3 different places, which not define it in ChannelVersion's companion object ?
sstone
approved these changes
Jul 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is better suited for composition of features.
This paves the way for #1026.