Skip to content

Switch varint codec to big-endian.#1075

Merged
t-bast merged 1 commit intomasterfrom
varint-big-endian
Jul 15, 2019
Merged

Switch varint codec to big-endian.#1075
t-bast merged 1 commit intomasterfrom
varint-big-endian

Conversation

@t-bast
Copy link
Member

@t-bast t-bast commented Jul 15, 2019

As described in this spec PR (approved by all three implementations): lightning/bolts#640

@t-bast t-bast requested review from pm47 and sstone July 15, 2019 09:28
@codecov-io
Copy link

Codecov Report

Merging #1075 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1075      +/-   ##
==========================================
+ Coverage    82.5%   82.59%   +0.08%     
==========================================
  Files          99       99              
  Lines        7592     7591       -1     
  Branches      300      300              
==========================================
+ Hits         6264     6270       +6     
+ Misses       1328     1321       -7
Impacted Files Coverage Δ
...main/scala/fr/acinq/eclair/wire/CommonCodecs.scala 97.56% <100%> (-0.06%) ⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 84.16% <0%> (+0.28%) ⬆️
...src/main/scala/fr/acinq/eclair/router/Router.scala 86.76% <0%> (+0.94%) ⬆️

@t-bast t-bast merged commit 62946a0 into master Jul 15, 2019
@t-bast t-bast deleted the varint-big-endian branch July 15, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants