Conversation
t-bast
commented
Jul 17, 2019
eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
Outdated
Show resolved
Hide resolved
araspitzu
reviewed
Jul 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
=========================================
+ Coverage 82.6% 82.71% +0.1%
=========================================
Files 99 99
Lines 7594 7612 +18
Branches 293 295 +2
=========================================
+ Hits 6273 6296 +23
+ Misses 1321 1316 -5
|
pm47
requested changes
Jul 17, 2019
eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
Outdated
Show resolved
Hide resolved
Add more tests and fix edge cases.
pm47
requested changes
Jul 19, 2019
Member
pm47
left a comment
There was a problem hiding this comment.
There is still the issue of the uptream channel being in state OFFLINE when we receive the fulfill. We could check the PendingRelayDb for available CMD_FULFILL_HTLC when we enter the fulfill-safety-before-timeout-blocks and fail the channel, which would cause the CommandBuffer to re-send the command.
eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
Outdated
Show resolved
Hide resolved
sstone
reviewed
Jul 19, 2019
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/OfflineStateSpec.scala
Show resolved
Hide resolved
pm47
approved these changes
Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.