Skip to content

Merge branch 'v0.3.0-dev' into develop#433

Merged
cffls merged 93 commits into
0xPolygon:developfrom
cffls:develop
Jun 22, 2022
Merged

Merge branch 'v0.3.0-dev' into develop#433
cffls merged 93 commits into
0xPolygon:developfrom
cffls:develop

Conversation

@cffls

@cffls cffls commented Jun 15, 2022

Copy link
Copy Markdown
Contributor

This PR will merge everything from v0.3.0-dev into develop branch.

manav2401 and others added 30 commits May 9, 2022 17:03
* Protobuf tooling fix and upgrade

* Paths for protobuf files has changed, reflect that in Makefile
* Fix the tooling to make it work in macos
* Update protoc version and regenarate files.

* Regen proto
* Build and run the new CLI
* update the default cli config

* fix: handle maxpeers flag override, added tests

* add: no-snapshot flag, handle snapshot disable

* fix: update default flags

* add: update the sealer.GasPrice default to 30 gewi

* fix: remove snapshot flag, rely on no-snapshot only
Adding a script that can automatically generate markdown pages from bor
CLI, so we can avoid copy-pasting helper strings whenever a flag is created,
deleted, or modified.

CLI docs could be generated with command `make docs`.
Fix prometheus path and add prometheus to bor.service
cffls and others added 9 commits May 31, 2022 20:30
…considered as empty

This change will fix two issues:
1. When CLI sets a flag to an empty value in Go, e.g. 0 as to Uint64, the flag will be skipped and never set correctly. This problem could be solved by using option "WithOverwriteWithEmptyValue" when merge two configs.
2. The default non-empty value in server config will be overwritten to an empty value after flag initialization. This problem is solved by explicitly providing default value to all flags that have a default value option.
* bad block tracing

* Add debug env framework

* add implementation of custom block tracing

* add few comments

* use tar name fn

* wip: add unit tests for block tracing

* complete test for block tracer

* fix: close grpc server

* refactor cli tests

* fix: change condition for parsing args

* Fix port binding for test server

* add helper for creating and closing mock server for tests

* consume mock server in tests

* fixes due to geth merge

* fix: handle port selection for http server

* update help and markdown for debug command

* update docs

* update debug synopsis

* fix: use chunked encoder to handle large data over grpc

* fix prints

* lint

* rm unused function, rename fn to TraceBorBlock

Co-authored-by: Ferran Borreguero <ferranbt@protonmail.com>
* Limit state sync by gas

* Added logging for state-sync total gas usage

* Added number of event-records in log

* Minor Changes

* Minor Fix

* Adding individual gasUsed

* Minor Fix

* it works

* fix tests

* log wiggle and delay with block number

* log delays as numbers

* linters

* fix tests

* restore linters for the project

* fix linters

* fix

* fix

* fix

* linters

* generation

* fix tests

* remove heimdall wrapper response

* linters

* remove possible collisions

* remove possible collisions

* remove possible collisions

* tests for unique address generation

* generalize set

* bor miner tests got restored

* fixes after CR

* final step and mining test

* fix

* fix e2e

* more tests for Heimdall requests

* fix linters

Co-authored-by: Ferran <ferranbt@protonmail.com>
Co-authored-by: Shivam Sharma <shivam691999@gmail.com>
* merge geth v1.10.15

* fix: Removed FastSync from cli server

* fix: TestHeadersRLPStorage

* Added t.skip(ETH2 in bor)

* fix: flow in create consensus engine

* bumped version

* Fix typo

* increase block time

* remove file

* bumped version

* merge gethv1.10.17

* bumped version

* fix failing tests

* Bump Go version to v1.18 (0xPolygon#368)

* Bump Go version to v1.18.1

* Build using netgo tag

This will create a static build using Go native networking stack.

Checked and it works stable for all archs and distros.

* Fix meta

* initial implementation for common ancestor approach

* extract whitelist interface

* fix types

* fix tests and format

* add unit tests for IsValidChain function

* more tests

* wip

* test ErrCheckpointMismatch

* minor fixes

* fix test

* dont panic

* fmt

* Limit state sync by gas

* Added logging for state-sync total gas usage

* Added number of event-records in log

* Minor Changes

* Minor Fix

* Adding individual gasUsed

* Minor Fix

* fix: return value for no remote block

* handle all errors

* modularise fake chain validator in downloader

* add more tests

* fix tests

* Modifying miner.recommit flag and its adjustment function. (0xPolygon#370)

* changed min/max/current recommit values

* Remove Hardcoded min/max

* Code Sanitization

* Skipping tests for constant recommit interval

* Adding default miner.recommit value

* Minor Change

* Increased default value of rpc.txfeecap to 5

* add debug rpc endpoints for checkpoint whitelist service

* minor fixes and enhancements

* avoid capping warnings for gas set by internal system transactions

* use typed mocks

* fix

* fix

* fix

* fix close

* fix

* Create stale.yml

* Fix bor consensus checkpoint bug

Co-authored-by: Arpit Temani <temaniarpit27@gmail.com>
Co-authored-by: Shivam Sharma <shivam691999@gmail.com>
Co-authored-by: Manav Darji <manavdarji.india@gmail.com>
Co-authored-by: Sandeep Sreenath <sandeep.sreenath@gmail.com>
Co-authored-by: Victor Castell <victor@victorcastell.com>
Co-authored-by: Ferran <ferranbt@protonmail.com>
Co-authored-by: Krishna Upadhyaya <krishnau1604@gmail.com>
Co-authored-by: Karlo <karlonovak@gmail.com>
Co-authored-by: Sandeep Sreenath <ssandeep@users.noreply.github.com>
Co-authored-by: Jerry <jerrycgh@gmail.com>
@codecov-commenter

codecov-commenter commented Jun 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #433 (15733d5) into develop (3bb1480) will decrease coverage by 0.47%.
The diff coverage is 12.39%.

@@             Coverage Diff             @@
##           develop     #433      +/-   ##
===========================================
- Coverage    56.67%   56.19%   -0.48%     
===========================================
  Files          580      596      +16     
  Lines        68428    68926     +498     
===========================================
- Hits         38780    38734      -46     
- Misses       26285    26854     +569     
+ Partials      3363     3338      -25     
Impacted Files Coverage Δ
consensus/bor/api.go 0.00% <0.00%> (ø)
consensus/bor/bor.go 7.70% <0.00%> (+1.54%) ⬆️
consensus/bor/errors.go 0.00% <ø> (ø)
consensus/bor/genesis_contract_mock.go 0.00% <0.00%> (ø)
consensus/bor/merkle.go 0.00% <0.00%> (ø)
consensus/bor/snapshot.go 14.77% <0.00%> (+0.94%) ⬆️
consensus/bor/span_mock.go 0.00% <0.00%> (ø)
consensus/bor/validators_getter_mock.go 0.00% <0.00%> (ø)
core/blockchain_reader.go 43.44% <0.00%> (-3.23%) ⬇️
core/chain_makers.go 68.21% <0.00%> (-1.87%) ⬇️
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb1480...15733d5. Read the comment docs.

Comment thread consensus/bor/bor.go Outdated

@JekaMas JekaMas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about checking nil interface

@temaniarpit27 temaniarpit27 requested a review from a team June 17, 2022 09:47
temaniarpit27
temaniarpit27 previously approved these changes Jun 17, 2022
JekaMas
JekaMas previously approved these changes Jun 22, 2022
@cffls cffls merged commit 88dbfa1 into 0xPolygon:develop Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants