Skip to content

Merge develop branch into v0.3.0-dev#430

Merged
JekaMas merged 64 commits into
v0.3.0-devfrom
merge-develop-branch
Jun 15, 2022
Merged

Merge develop branch into v0.3.0-dev#430
JekaMas merged 64 commits into
v0.3.0-devfrom
merge-develop-branch

Conversation

@JekaMas

@JekaMas JekaMas commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@JekaMas JekaMas requested a review from cffls June 14, 2022 09:52
@codecov-commenter

codecov-commenter commented Jun 14, 2022

Copy link
Copy Markdown

Codecov Report

Merging #430 (24c7eb7) into v0.3.0-dev (2323f2c) will increase coverage by 0.50%.
The diff coverage is 16.48%.

@@              Coverage Diff               @@
##           v0.3.0-dev     #430      +/-   ##
==============================================
+ Coverage       55.74%   56.25%   +0.50%     
==============================================
  Files             601      596       -5     
  Lines           69602    68921     -681     
==============================================
- Hits            38803    38774      -29     
+ Misses          27447    26805     -642     
+ Partials         3352     3342      -10     
Impacted Files Coverage Δ
consensus/bor/api.go 0.00% <0.00%> (ø)
consensus/bor/bor.go 7.70% <0.00%> (+1.47%) ⬆️
consensus/bor/errors.go 0.00% <0.00%> (ø)
consensus/bor/genesis_contract_mock.go 0.00% <0.00%> (ø)
consensus/bor/merkle.go 0.00% <0.00%> (ø)
consensus/bor/snapshot.go 14.77% <0.00%> (+0.94%) ⬆️
consensus/bor/span_mock.go 0.00% <0.00%> (ø)
consensus/bor/validators_getter_mock.go 0.00% <0.00%> (ø)
core/blockchain_reader.go 43.44% <0.00%> (-3.23%) ⬇️
core/chain_makers.go 68.21% <0.00%> (-1.87%) ⬇️
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c8bf51...24c7eb7. Read the comment docs.

@temaniarpit27

Copy link
Copy Markdown
Contributor

@JekaMas can we raise v0.3.0-dev to develop and merge in develop itself?

@JekaMas

JekaMas commented Jun 14, 2022

Copy link
Copy Markdown
Contributor Author

@JekaMas can we raise v0.3.0-dev to develop and merge in develop itself?

We can. Basically this PR is a part of that plan. Merge develop to v0.3.0-dev, resolve all conflicts, fix CI, then merge v0.3.0-dev without conflicts.

@cffls cffls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and fixed a bug related to checkpoint. State sync seems to be working fine.

@JekaMas JekaMas merged commit 342bf30 into v0.3.0-dev Jun 15, 2022
@temaniarpit27 temaniarpit27 deleted the merge-develop-branch branch June 24, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants