Add bootnode cli#381
Merged
Merged
Conversation
Contributor
|
Could you give me a bit of a context, why we need this change? What is the goal? |
Contributor
Author
Added the context to the PR's description. Thanks! |
JekaMas
approved these changes
May 5, 2022
vcastellm
reviewed
May 9, 2022
Codecov Report
@@ Coverage Diff @@
## v0.3.0-dev #381 +/- ##
==============================================
- Coverage 55.89% 55.84% -0.06%
==============================================
Files 600 601 +1
Lines 69416 69537 +121
==============================================
+ Hits 38801 38831 +30
- Misses 27256 27353 +97
+ Partials 3359 3353 -6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is mostly copied from v3's bootnode implementation [1]
bootnodeis a binary currently built from bootnode module [2] under cmd. Other than serving as a bootnode (for p2p), we also use it during setup of validator and sentry node to get their node ids, see example here. In the new CLI (v0.3.0), our goal is to changebootnodefrom a standalone binary to a subcommand underborbinary. In branchv0.3.0-dev, thisbootnodebinary is already removed from installation package (e.g. .deb, .rpm). This commit is to makebootnodeas a subcommand ofbor. Eventually, we will remove the original bootnode module [2] and keep the new file introduced in this commit.[1] v3 bootnode: https://github.com/maticnetwork/v3/blob/main/internal/cli/bootnode.go
[2] bootnode module: https://github.com/maticnetwork/bor/blob/master/cmd/bootnode/main.go