Update default cli config#323
Merged
Merged
Conversation
Contributor
|
Is Http enabled by default? |
Member
Author
|
@ferranbt No it wasn't, but last week we enabled it, thinking that we can always disable by passing the |
Contributor
|
So, what is the end goal? Http enabled or not? |
ssandeep
approved these changes
Feb 11, 2022
0xsharma
approved these changes
Mar 24, 2022
0xsharma
reviewed
Mar 24, 2022
Member
Author
|
Have updated the default flags with newly decided values. |
ferranbt
approved these changes
Apr 5, 2022
ferranbt
suggested changes
Apr 5, 2022
0xsharma
approved these changes
Apr 20, 2022
temaniarpit27
approved these changes
Apr 20, 2022
ferranbt
approved these changes
Apr 26, 2022
vcastellm
pushed a commit
that referenced
this pull request
May 9, 2022
* update the default cli config * fix: handle maxpeers flag override, added tests * add: no-snapshot flag, handle snapshot disable * fix: update default flags * add: update the sealer.GasPrice default to 30 gewi * fix: remove snapshot flag, rely on no-snapshot only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does following things
no-snapshotflag, which will be used to disable the snapshot database mode.