Skip to content

Fix default Dockerfile for new CLI#417

Merged
cffls merged 1 commit into
0xPolygon:v0.3.0-devfrom
cffls:v0.3.0-dev-lint
Jun 2, 2022
Merged

Fix default Dockerfile for new CLI#417
cffls merged 1 commit into
0xPolygon:v0.3.0-devfrom
cffls:v0.3.0-dev-lint

Conversation

@cffls

@cffls cffls commented May 27, 2022

Copy link
Copy Markdown
Contributor
  • make bor-all will stop working in v0.3.0, changing the target to bor instead.
  • Also fix a minor bug in logger.

@codecov-commenter

codecov-commenter commented May 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #417 (5092006) into v0.3.0-dev (2323f2c) will increase coverage by 0.60%.
The diff coverage is 10.34%.

@@              Coverage Diff               @@
##           v0.3.0-dev     #417      +/-   ##
==============================================
+ Coverage       55.74%   56.35%   +0.60%     
==============================================
  Files             601      593       -8     
  Lines           69602    68903     -699     
==============================================
+ Hits            38803    38833      +30     
+ Misses          27447    26727     -720     
+ Partials         3352     3343       -9     
Impacted Files Coverage Δ
consensus/bor/api.go 0.00% <0.00%> (ø)
consensus/bor/bor.go 6.20% <0.00%> (-0.03%) ⬇️
consensus/bor/clerk.go 0.00% <ø> (ø)
consensus/bor/genesis_contracts_client.go 0.00% <ø> (ø)
consensus/bor/merkle.go 0.00% <0.00%> (ø)
consensus/bor/rest.go 0.00% <0.00%> (ø)
consensus/bor/snapshot.go 14.28% <0.00%> (+0.45%) ⬆️
consensus/bor/validator.go 20.68% <ø> (+6.89%) ⬆️
internal/cli/account.go 0.00% <ø> (ø)
internal/cli/account_import.go 0.00% <ø> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96228cc...5092006. Read the comment docs.

@vcastellm vcastellm left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cffls cffls merged commit 4ffdbfe into 0xPolygon:v0.3.0-dev Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants