Release 4.6.0 by asottile · Pull Request #5350 · pytest-dev/pytest

asottile · 2019-05-31T16:02:40Z

🎉 🎆 🎉 🎆 🎉

Merge master into features

It was not really testing what it was supposed to test (e.g. the inner test was not run in the first place).

Merge master to fix CI

…-features

Merge master into features (make CI green again)

This can provide useful information, e.g. > could not import 'pyrepl.readline': curses library not found

Do not cut long help texts, but wrap them the same way as argparse wraps the other help items.

importorskip: display/include ImportError

tests: fix test_trace_after_runpytest

tests: harden test_nonascii_text

Improve output of ini options in --help

reportopts: A: put "Pp" in front

…nrolled for loop

This reverts commit 043fdb7. These tests were part of the PR #5155 but weren't relevant to #5602

…ting The code ``` x = 0 assert x == 1 ``` will give the failure message 0 == 1, so it shouldn't be different as part of an unroll

pdb: move/refactor initialization of PytestPdbWrapper

Follow-up to c86d2da.

pytester: remove unused winpymap

tests: conftest: auto-add slow marker

Merge master into features

Followup to #4956.

…docs Add missing junitxml ini options to the reference docs

pytester: use temporary HOME with spawn

ci: Travis: add pypy3 to allowed failures temporarily

logging: Improve formatting of multiline message

Merge master into features

codecov · 2019-05-31T16:29:33Z

Codecov Report

Merging #5350 into master will decrease coverage by 3.44%.
The diff coverage is 90.93%.

@@            Coverage Diff             @@
##           master    #5350      +/-   ##
==========================================
- Coverage   94.12%   90.67%   -3.45%     
==========================================
  Files         115      115              
  Lines       26303    26384      +81     
  Branches     2592     2607      +15     
==========================================
- Hits        24757    23923     -834     
- Misses       1229     2129     +900     
- Partials      317      332      +15

Impacted Files	Coverage Δ
testing/test_session.py	`100% <ø> (ø)`	⬆️
src/_pytest/compat.py	`96.98% <ø> (-0.02%)`	⬇️
testing/test_terminal.py	`94.4% <100%> (-5.14%)`	⬇️
src/_pytest/config/__init__.py	`93.79% <100%> (-0.01%)`	⬇️
testing/test_pytester.py	`55.21% <100%> (-27.45%)`	⬇️
src/_pytest/pytester.py	`85.31% <100%> (-4.5%)`	⬇️
src/_pytest/fixtures.py	`97.55% <100%> (ø)`	⬆️
testing/test_junitxml.py	`97.96% <100%> (+0.02%)`	⬆️
src/_pytest/junitxml.py	`95.9% <100%> (+0.04%)`	⬆️
testing/test_assertion.py	`97.67% <100%> (ø)`	⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f360147...e7cd00a. Read the comment docs.

nicoddemus

🎉

asottile · 2019-05-31T17:46:04Z

@nicoddemus an idea why codecov/patch hasn't reported? can I ignore that and continue?

nicoddemus · 2019-05-31T19:10:31Z

@nicoddemus an idea why codecov/patch hasn't reported? can I ignore that and continue?

No idea why, but let's wait for @blueyed's review regardless. 👍

blueyed · 2019-05-31T21:43:35Z

Codecov likely got confused (reported -4% drop at https://codecov.io/gh/pytest-dev/pytest/pull/5350/changes).
(I can imagine this happens when the merge commit advanced already or something like that (similar to how Travis does not build the actual commit to be tested when you push a new commit before it gets to this job))

blueyed · 2019-05-31T21:50:33Z

I'd say to wait for CI to pass before rebasing this for fixed changelogs (with regard to codecov).

nicoddemus · 2019-06-01T12:49:24Z

Ready for the release! 🎉

jeffreyrack and others added 30 commits April 4, 2019 20:26

Added the junit_log_passing_tests ini flag.

da3f836

minor: improve formatting

0b8b006

Merge master into features (#5248)

cc464f6

Merge master into features

tests: fix test_trace_after_runpytest

dda2193

It was not really testing what it was supposed to test (e.g. the inner test was not run in the first place).

minor: settrace != set_trace

f8e1d58

minor: s/no covers/no cover/

c081c01

Merge master into features

2db05b6

Merge pull request #5263 from blueyed/mm

c0e53a6

Merge master to fix CI

Merge remote-tracking branch 'upstream/master' into merge-master-into…

041ea37

…-features

Merge pull request #5281 from nicoddemus/merge-master-into-features

0f7c7a9

Merge master into features (make CI green again)

tests: harden test_nonascii_text

ff428bf

importorskip: display/include ImportError

d19df5e

This can provide useful information, e.g. > could not import 'pyrepl.readline': curses library not found

Improve output of ini options in --help

b2ce6f3

Do not cut long help texts, but wrap them the same way as argparse wraps the other help items.

reportopts: A: put "Pp" in front

f9f41e6

importorskip: display/include ImportError (#5269)

b900b41

importorskip: display/include ImportError

tests: fix test_trace_after_runpytest (#5245)

6ba5e3c

tests: fix test_trace_after_runpytest

Merge pull request #5268 from blueyed/harden-test

ec6d0fa

tests: harden test_nonascii_text

Merge pull request #5091 from blueyed/showhelp-ini-options

b4d75ad

Improve output of ini options in --help

Merge pull request #5119 from blueyed/reportopts-A-order

10ca84f

reportopts: A: put "Pp" in front

Sanity tests for loop unrolling

6b5152a

Replace asserts of any with an assert in a for

765f75a

Rewrite unrolled assertion with a new rewriter,correctly append the u…

470e686

…nrolled for loop

Add changelog entry for 5062

ddbe733

Adding test cases for unrolling an iterable #5062

a0dbf2a

Displaying pip list command's packages and versions #5062

0996f3d

Fixed test case

c607697

Revert "Displaying pip list command's packages and versions #5062"

ecd2de2

This reverts commit 043fdb7. These tests were part of the PR #5155 but weren't relevant to #5602

Check calls to all only if it's a name and not an attribute

e37ff30

Expand list comprehensions as well

437d645

Change basic test case to be consistent with existing assertion rewri…

852fb6a

…ting The code ``` x = 0 assert x == 1 ``` will give the failure message 0 == 1, so it shouldn't be different as part of an unroll

blueyed and others added 14 commits May 30, 2019 06:39

Merge pull request #5322 from blueyed/pdb-wrapper

d6ce2e5

pdb: move/refactor initialization of PytestPdbWrapper

tests: conftest: auto-add slow marker

28bf381

pytester: remove unused winpymap

da23aa3

Follow-up to c86d2da.

Merge pull request #5343 from blueyed/remove-winpymap

843ca03

pytester: remove unused winpymap

Merge pull request #5341 from blueyed/auto-slow

737a1bf

tests: conftest: auto-add slow marker

Merge master into features (#5339)

fbd8ff9

Merge master into features

pytester: use temporary HOME with spawn

f013a5e

Followup to #4956.

pytester: factor out testdir._env_run_update

ace3a02

Merge pull request #5338 from nicoddemus/junit_log_passing_tests-ref-…

56e430f

…docs Add missing junitxml ini options to the reference docs

Merge pull request #5306 from blueyed/spawn-home

882f3a4

pytester: use temporary HOME with spawn

ci: Travis: add pypy3 to allowed failures temporarily (#5340)

c5de8e8

ci: Travis: add pypy3 to allowed failures temporarily

logging: Improve formatting of multiline message (#5312)

c8d23c2

logging: Improve formatting of multiline message

Merge remote-tracking branch 'origin/master' into mm

fb3ae5e

Merge pull request #5349 from asottile/mm

693c3b7

Merge master into features

asottile requested review from blueyed and nicoddemus May 31, 2019 16:22

nicoddemus approved these changes May 31, 2019

View reviewed changes

Comment thread CHANGELOG.rst

nicoddemus reviewed May 31, 2019

View reviewed changes

Comment thread CHANGELOG.rst

blueyed closed this May 31, 2019

blueyed reopened this May 31, 2019

blueyed approved these changes May 31, 2019

View reviewed changes

Comment thread CHANGELOG.rst Outdated

Comment thread CHANGELOG.rst Outdated

Comment thread CHANGELOG.rst Outdated

Comment thread CHANGELOG.rst Outdated

Comment thread CHANGELOG.rst Outdated

Preparing release version 4.6.0

e7cd00a

asottile merged commit 917195e into pytest-dev:master Jun 1, 2019

asottile deleted the release-4.6.0 branch June 1, 2019 18:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release 4.6.0#5350

Release 4.6.0#5350
asottile merged 69 commits into
pytest-dev:masterfrom
asottile:release-4.6.0

asottile commented May 31, 2019

Uh oh!

codecov Bot commented May 31, 2019 •

edited

Loading

Uh oh!

nicoddemus left a comment

Uh oh!

Uh oh!

Uh oh!

asottile commented May 31, 2019

Uh oh!

nicoddemus commented May 31, 2019

Uh oh!

blueyed commented May 31, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blueyed commented May 31, 2019

Uh oh!

nicoddemus commented Jun 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

asottile commented May 31, 2019

Uh oh!

codecov Bot commented May 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nicoddemus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

asottile commented May 31, 2019

Uh oh!

nicoddemus commented May 31, 2019

Uh oh!

blueyed commented May 31, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blueyed commented May 31, 2019

Uh oh!

nicoddemus commented Jun 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov Bot commented May 31, 2019 •

edited

Loading