Skip to content

pytester: remove unused winpymap#5343

Merged
nicoddemus merged 1 commit into
pytest-dev:featuresfrom
blueyed:remove-winpymap
May 30, 2019
Merged

pytester: remove unused winpymap#5343
nicoddemus merged 1 commit into
pytest-dev:featuresfrom
blueyed:remove-winpymap

Conversation

@blueyed

@blueyed blueyed commented May 30, 2019

Copy link
Copy Markdown
Contributor

Follow-up to c86d2da.

@codecov

codecov Bot commented May 30, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5343 into features will decrease coverage by 5.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5343      +/-   ##
============================================
- Coverage     93.59%   88.42%   -5.17%     
============================================
  Files           115      115              
  Lines         26307    26306       -1     
  Branches       2600     2600              
============================================
- Hits          24622    23262    -1360     
- Misses         1377     2716    +1339     
- Partials        308      328      +20
Impacted Files Coverage Δ
src/_pytest/pytester.py 84.68% <ø> (-1.44%) ⬇️
testing/test_reports.py 10.49% <0%> (-89.51%) ⬇️
testing/logging/test_reporting.py 21.03% <0%> (-78.97%) ⬇️
testing/test_runner_xunit.py 29.82% <0%> (-70.18%) ⬇️
testing/examples/test_issue519.py 33.33% <0%> (-66.67%) ⬇️
testing/test_runner.py 34.7% <0%> (-61.61%) ⬇️
testing/test_resultlog.py 53.6% <0%> (-46.4%) ⬇️
src/_pytest/reports.py 68.96% <0%> (-26.11%) ⬇️
testing/python/fixtures.py 73.53% <0%> (-24.98%) ⬇️
testing/test_warnings.py 26.77% <0%> (-21.86%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6ce2e5...da23aa3. Read the comment docs.

@blueyed

blueyed commented May 30, 2019

Copy link
Copy Markdown
Contributor Author

Also here pypy3-xdist was ok.

@nicoddemus

nicoddemus commented May 30, 2019

Copy link
Copy Markdown
Member

Also here pypy3-xdist was ok.

🤔

I wonder if features pypy3 is fine, only failing on master.

If this is the case, I would just go ahead and release 4.6, because afterwards we will merge features into master and the problem goes away. 😅

@nicoddemus nicoddemus merged commit 843ca03 into pytest-dev:features May 30, 2019
@blueyed blueyed deleted the remove-winpymap branch May 30, 2019 15:02
@blueyed

blueyed commented May 30, 2019

Copy link
Copy Markdown
Contributor Author

I wonder if features pypy3 is fine, only failing on master.

No, it started failing on features - but now appears to be OK again?!
Have not investigated (i.e. not checked new commits to features really), but from this morning it looked like something else might have caused it (e.g. load on Travis?!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blueyed @nicoddemus