reportopts: A: put "Pp" in front#5119
Merged
Merged
Conversation
9b9b97f to
ae33279
Compare
Codecov Report
@@ Coverage Diff @@
## features #5119 +/- ##
============================================
+ Coverage 91.33% 92.27% +0.94%
============================================
Files 115 115
Lines 26165 26165
Branches 2578 2578
============================================
+ Hits 23897 24144 +247
+ Misses 1940 1695 -245
+ Partials 328 326 -2
Continue to review full report at Codecov.
|
asottile
approved these changes
Apr 15, 2019
asottile
left a comment
Member
There was a problem hiding this comment.
change looks fine, make sure it works well before shipping 👍
Member
|
Ping @blueyed to solve the conflicts |
ae33279 to
f9f41e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No changelog, followup to #5068.
Have not really checked if this is sane yet, but "P" means to provide the output of the passed tests, and "p" to include it in the summary - where it should come first also then.