Merge master into features#5339
Merged
nicoddemus merged 11 commits intoMay 30, 2019
Merged
Conversation
Fix regression with --lf and non-selected failures
Uses `PYTEST_COVERAGE=1` already, which will come in via dropping Python 2 soon anyway.
Fix pexpect tests on MacOS
Codecov Report
@@ Coverage Diff @@
## features #5339 +/- ##
============================================
- Coverage 92.4% 89.92% -2.49%
============================================
Files 115 115
Lines 26294 26455 +161
Branches 2597 2631 +34
============================================
- Hits 24297 23789 -508
- Misses 1677 2330 +653
- Partials 320 336 +16
Continue to review full report at Codecov.
|
Contributor
Author
|
Hmm, pypy3 did not fail here - restarted it. /cc @nicoddemus |
Member
|
Working again... do we see those failures on |
Contributor
Author
What do you mean? Can we merge this? |
Member
I mean't pypy3, sorry.
Oops sure |
nicoddemus
approved these changes
May 30, 2019
Contributor
Author
|
Re pypy3: it's been an issue on features, not master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, again for #5306.