Skip to content

tests: harden test_nonascii_text#5268

Merged
blueyed merged 1 commit into
pytest-dev:featuresfrom
blueyed:harden-test
May 23, 2019
Merged

tests: harden test_nonascii_text#5268
blueyed merged 1 commit into
pytest-dev:featuresfrom
blueyed:harden-test

Conversation

@blueyed

@blueyed blueyed commented May 15, 2019

Copy link
Copy Markdown
Contributor

No changelog.

@codecov

codecov Bot commented May 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5268 into features will increase coverage by 1.52%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           features   #5268      +/-   ##
===========================================
+ Coverage     92.07%   93.6%   +1.52%     
===========================================
  Files           115     115              
  Lines         26159   26161       +2     
  Branches       2578    2579       +1     
===========================================
+ Hits          24086   24487     +401     
+ Misses         1746    1358     -388     
+ Partials        327     316      -11
Impacted Files Coverage Δ
testing/test_assertion.py 97.67% <100%> (ø) ⬆️
testing/python/collect.py 45.2% <0%> (-53.74%) ⬇️
testing/python/integration.py 80.71% <0%> (-10.72%) ⬇️
src/_pytest/compat.py 94.97% <0%> (-2.02%) ⬇️
src/_pytest/main.py 95.61% <0%> (-0.44%) ⬇️
src/_pytest/fixtures.py 97.93% <0%> (+0.13%) ⬆️
src/_pytest/python.py 93.34% <0%> (+0.24%) ⬆️
src/_pytest/runner.py 98.01% <0%> (+1.19%) ⬆️
testing/test_terminal.py 80.87% <0%> (+1.55%) ⬆️
testing/python/metafunc.py 94.66% <0%> (+2.38%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e53a6...217e32a. Read the comment docs.

@codecov

codecov Bot commented May 15, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5268 into features will increase coverage by 1.65%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5268      +/-   ##
============================================
+ Coverage     91.33%   92.98%   +1.65%     
============================================
  Files           115      115              
  Lines         26165    26167       +2     
  Branches       2578     2579       +1     
============================================
+ Hits          23897    24332     +435     
+ Misses         1940     1507     -433     
  Partials        328      328
Impacted Files Coverage Δ
testing/test_assertion.py 97.67% <100%> (ø) ⬆️
testing/test_tmpdir.py 75.8% <0%> (-23.12%) ⬇️
testing/python/show_fixtures_per_test.py 85.29% <0%> (-14.71%) ⬇️
testing/python/integration.py 80.71% <0%> (-10.72%) ⬇️
testing/python/metafunc.py 87.31% <0%> (-7.91%) ⬇️
src/_pytest/tmpdir.py 96.55% <0%> (-3.45%) ⬇️
testing/python/collect.py 84.43% <0%> (-3.42%) ⬇️
src/_pytest/compat.py 93.96% <0%> (-3.02%) ⬇️
testing/test_terminal.py 79.31% <0%> (-2.96%) ⬇️
testing/python/fixtures.py 96.56% <0%> (-1.95%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f7c7a9...ff428bf. Read the comment docs.

@blueyed blueyed requested a review from RonnyPfannschmidt May 23, 2019 06:41
@blueyed blueyed merged commit ec6d0fa into pytest-dev:features May 23, 2019
@blueyed blueyed deleted the harden-test branch May 23, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@RonnyPfannschmidt RonnyPfannschmidt Awaiting requested review from RonnyPfannschmidt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blueyed @nicoddemus