Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/nodejs-storage
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.15.3
Choose a base ref
...
head repository: googleapis/nodejs-storage
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.15.4
Choose a head ref
  • 18 commits
  • 27 files changed
  • 9 contributors

Commits on Oct 18, 2021

  1. refactor: Unify precondition retry logic (#1660)

    * refactor: Unify retry logic
    
    * refactor: Use `PreconditionOptions` for determining if a request should be retried
    
    * refactor: Rename `shouldRetryRequest` to `shouldRetryBasedOnPreconditionAndIdempotencyStrat`
    
    * docs: Method should be used for `ifGenerationMatch`
    
    We can extend the function when we require `IfMetagenerationMatch` checking in this class
    danielbankhead authored Oct 18, 2021
    Configuration menu
    Copy the full SHA
    746420e View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. chore(cloud-rad): fix links in docs (#1669)

    See internally: b/203065829
    
    Script used:
    
    sed -i -e 's/@see \[\(.*\)\]{@link \(.*\)}$/See {@link \2| \1}/' src/*
    fhinkel authored Oct 19, 2021
    Configuration menu
    Copy the full SHA
    9babd50 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. samples: remove name from the submit field (#1671)

    * samples: remove name from the submit field
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * updated quote type for test
    
    * updated quote type for test
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * updated quote type for test
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    shaffeeullah and gcf-owl-bot[bot] authored Oct 20, 2021
    Configuration menu
    Copy the full SHA
    c5b34c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Configuration menu
    Copy the full SHA
    b804630 View commit details
    Browse the repository at this point in the history
  2. test: conformance testing for retries (#1566)

    * feat: added library methods for conformance testing (#1553)
    
    * feat: added library methods for conformance testing
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * fixed header
    
    * responded to PR comment, addressed some TODOs
    
    * resolved TODO
    
    * removed functions that dont make requests
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    
    * feat: add method mapping json file (#1569)
    
    * feat: add method mapping json file
    
    * add deleteResumableCache to mapping
    
    * WIP: retry strategy runner code (#1567)
    
    * feat: retry strategy runner code
    
    * fixed license
    
    * removed unused option
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * built out tests further, still doesnt work
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * built out more functionality
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * began refactor
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * moved functions
    
    * refactored code
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * Update libraryMethods.ts
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    
    * fix: fixed runtime errors. all the tests still fail, but they run now (#1591)
    
    * fix: fixed runtime errors. all the tests still fail, but they run now
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    
    * fix: exported functions
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * test: pull testbench docker image, kokoro presubmit conformance test … (#1590)
    
    * test: pull testbench docker image, kokoro presubmit conformance test hooks
    
    * use async function instead of explicit promise return
    
    * move file to node12 directory
    
    * fix file naming and linter issues
    
    * fix: retry strategy bug fixes (#1594)
    
    * bug fixes
    
    * removed logs
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * some tests pass
    
    * fixed some more tests
    
    * saves file
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * uncommented functions
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * removed duplicate storage definition
    
    * changed precondition options
    
    * down to 7 failing tests!
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    
    * feat: check that instructions were utilized in testbench (#1601)
    
    * feat: check that instructions were utilized in testbench
    
    * feedback
    
    * fix: remove all files from bucket before delete (#1603)
    
    * feat: move test creation and header set to beforeEach (#1605)
    
    * feat: move test creation and header set to beforeEach
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    
    * fix: create client for each test instead of globally (#1608)
    
    * fix: remove bucketGet (#1610)
    
    * fix: return promise from stream functions and resolve on end (#1612)
    
    * fix: move createReadStream to correct mapping location (#1613)
    
    * fix: remap bucket set storage class and bucket set metadata (#1615)
    
    * fix: remap bucket set storage class
    
    * fix: remap bucketSetMetadata
    
    * fix: fixed bucketUploadMultipart (#1627)
    
    * fix: fixed bucketUploadMultipart
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    
    * fix: conformance test fixes for deleteFiles, fileDelete, and copy (#1636)
    
    * fix: add copy to invocation map
    
    * fix: fix deleteFiles and fileDelete conformance tests
    
    * linter fixes
    
    * fix: only send metageneration to bucket related tests (#1641)
    
    * fix: remove tests for createWriteStream as the function is not retryable
    
    * fix: only send metageneration to bucket related tests
    
    * linter
    
    * fix: set retention period before file creation (#1651)
    
    * set retention period before file creation
    
    * removed log statement
    
    * removed log statement
    
    * fix: set correct bucket precondition (#1653)
    
    * fix: set correct bucket precondition
    
    * Update retryStrategy.ts
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    
    * fix: combine conformance test (#1656)
    
    * fix: update test bucket (#1657)
    
    * fix: combine conformance test
    
    * fix: only return bucket with preconditions if the test says so
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    
    * fix: fixed storage.objects.patch tests (#1658)
    
    * fix: fixed storage.objects.patch tests
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    
    * fix: refactor tests (#1659)
    
    * fix: refactor tests
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    
    * chore: build headers for isPublic from interceptors (#1665)
    
    * chore: build headers for isPublic from interceptors
    
    * simplify code
    
    * tests: removed failing tests (internal issue b/203793664) (#1674)
    
    * fix: add conformance project id (#1673)
    
    * fix: add conformance test project id settting
    
    * lint
    
    * increase timeout for before hook
    
    * specify correct host to docker port mapping
    
    * add stop command for docker container
    
    * chore: use import on json files instead of fs read (#1675)
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
    Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>
    4 people authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    d233c2b View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. chore(deps): update dependency @types/tmp to v0.2.2 (#1676)

    [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
    
    This PR contains the following updates:
    
    | Package | Change | Age | Adoption | Passing | Confidence |
    |---|---|---|---|---|---|
    | [@types/tmp](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`0.2.1` -> `0.2.2`](https://renovatebot.com/diffs/npm/@types%2ftmp/0.2.1/0.2.2) | [![age](https://badges.renovateapi.com/packages/npm/@types%2ftmp/0.2.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2ftmp/0.2.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2ftmp/0.2.2/compatibility-slim/0.2.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2ftmp/0.2.2/confidence-slim/0.2.1)](https://docs.renovatebot.com/merge-confidence/) |
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: "after 9am and before 3pm" (UTC).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
    
    ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
    
    ---
    
     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
    
    ---
    
    This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-storage).
    renovate-bot authored Oct 22, 2021
    Configuration menu
    Copy the full SHA
    84e837c View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Configuration menu
    Copy the full SHA
    d3fcc1f View commit details
    Browse the repository at this point in the history
  2. chore(cloud-rad): add code fencing for TSDoc (#1679)

    * chore(cloud-rad): add code fenzing for TSDoc
    
    Code examples need code fenzing around them to distingish from
    rich text for TSDoc.
    
    Internally b/179483748
    
    Script used:
    https://github.com/fhinkel/cloud-rad-script/blob/main/fixExampleComments.js
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    fhinkel and gcf-owl-bot[bot] authored Oct 27, 2021
    Configuration menu
    Copy the full SHA
    8fcb485 View commit details
    Browse the repository at this point in the history
  3. chore(cloud-rad): fix links for TSDocs (#1680)

    * chore: fix links with see
    
    * chore: links
    
    sed -i -e 's/@see \[\(.*\)\](\(.*\))$/See {@link \2| \1}/' src/*
    
    sed -i -e 's/\[\(.*\)\](\(.*\))/{@link \2| \1}/' src/*
    
    * fix links
    fhinkel authored Oct 27, 2021
    Configuration menu
    Copy the full SHA
    dad9301 View commit details
    Browse the repository at this point in the history
  4. tests: scenario 5 (#1684)

    * test: update retry test runner to properly parse throws
    
    * tests: add error handling
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * remapped bucket make public
    
    * use let instead of var
    
    * add scenario 5
    
    * removed error handler
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    shaffeeullah and gcf-owl-bot[bot] authored Oct 27, 2021
    Configuration menu
    Copy the full SHA
    e7d79d7 View commit details
    Browse the repository at this point in the history
  5. chore(deps): update dependency @types/node to v16 (#1677)

    * chore(deps): update dependency @types/node to v16
    
    * refactor: Help out `promisify` by providing types
    
    * chore(deps): update dependency @types/node to v16
    
    Co-authored-by: Daniel Bankhead <danielbankhead@google.com>
    renovate-bot and d-goog authored Oct 27, 2021
    Configuration menu
    Copy the full SHA
    f07b8f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Configuration menu
    Copy the full SHA
    31261f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. Configuration menu
    Copy the full SHA
    0623a29 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    56ff485 View commit details
    Browse the repository at this point in the history
  3. test: add test for undefined reason (#1691)

    * test: add test for undefined reason
    
    * 🦉 Updates from OwlBot
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    shaffeeullah and gcf-owl-bot[bot] authored Oct 29, 2021
    Configuration menu
    Copy the full SHA
    92e050c View commit details
    Browse the repository at this point in the history
  4. chore(cloud-rad): add code fencing for TSDoc (#1689)

    Instead of `<caption>` use rich text for examples.
    
    See #1679
    fhinkel authored Oct 29, 2021
    Configuration menu
    Copy the full SHA
    57bb180 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. Configuration menu
    Copy the full SHA
    10173c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4acc102 View commit details
    Browse the repository at this point in the history
Loading