This repository was archived by the owner on Mar 3, 2026. It is now read-only.
tests: scenario 5#1684
Merged
Merged
Conversation
…is/nodejs-storage into shaffeeullah/handleStreamErrors
ddelgrosso1
reviewed
Oct 27, 2021
| .on('end', () => resolve(undefined)); | ||
| .on('end', () => resolve(undefined)) | ||
| .on('error', err => reject(err)); | ||
| }).catch(() => { |
Contributor
There was a problem hiding this comment.
Can this be handled up a layer? If I understand this correctly if an error occurs the .on('error') handler will reject which is caught by this block which in turn throws an error. Can't the rejection be caught by the wrapping function?
Contributor
|
Just a general comment, do we want to go into main with these or work in another staging branch for the time being? |
Contributor
Author
I think we should have staging branches for each scenario and merge to main a scenario at a time. In this case, we don't need a staging branch because all of scenario 5 is passing. |
ddelgrosso1
approved these changes
Oct 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.