test: conformance testing for retries by shaffeeullah · Pull Request #1566 · googleapis/nodejs-storage

shaffeeullah · 2021-08-26T21:21:42Z

Conformance testing scenarios 1 & 2 with the exception of 4 tests tracked here (internal link)

generated-files-bot · 2021-09-21T14:33:33Z

Warning: This pull request is touching the following templated files:

.kokoro/conformance-test.sh - .kokoro files are templated and should be updated in synthtool
.kokoro/presubmit/node12/conformance-test.cfg - .kokoro files are templated and should be updated in synthtool

snippet-bot · 2021-10-04T19:58:47Z

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

* feat: added library methods for conformance testing * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fixed header * responded to PR comment, addressed some TODOs * resolved TODO * removed functions that dont make requests Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: add method mapping json file * add deleteResumableCache to mapping

* feat: retry strategy runner code * fixed license * removed unused option * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * built out tests further, still doesnt work * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * built out more functionality * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * began refactor * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * moved functions * refactored code * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update libraryMethods.ts Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…#1591) * fix: fixed runtime errors. all the tests still fail, but they run now * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

#1590) * test: pull testbench docker image, kokoro presubmit conformance test hooks * use async function instead of explicit promise return * move file to node12 directory * fix file naming and linter issues

* bug fixes * removed logs * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * some tests pass * fixed some more tests * saves file * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * uncommented functions * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * removed duplicate storage definition * changed precondition options * down to 7 failing tests! * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: check that instructions were utilized in testbench * feedback

* feat: move test creation and header set to beforeEach * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Denis DelGrosso <ddelgrosso@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: remap bucket set storage class * fix: remap bucketSetMetadata

* fix: fixed bucketUploadMultipart * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

) * fix: add copy to invocation map * fix: fix deleteFiles and fileDelete conformance tests * linter fixes

* fix: remove tests for createWriteStream as the function is not retryable * fix: only send metageneration to bucket related tests * linter

…feeullah/retryConformanceTesting

* set retention period before file creation * removed log statement * removed log statement

* fix: set correct bucket precondition * Update retryStrategy.ts * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…feeullah/retryConformanceTesting

* fix: combine conformance test * fix: only return bucket with preconditions if the test says so * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: fixed storage.objects.patch tests * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: refactor tests * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…feeullah/retryConformanceTesting

* chore: build headers for isPublic from interceptors * simplify code

…feeullah/retryConformanceTesting

* fix: add conformance test project id settting * lint * increase timeout for before hook * specify correct host to docker port mapping * add stop command for docker container

product-auto-label Bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Aug 26, 2021

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2021

shaffeeullah changed the title ~~feat: added library methods for conformance testing (#1553)~~ test: conformance testing for retries Aug 27, 2021

shaffeeullah added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 14, 2021

shaffeeullah and others added 18 commits October 6, 2021 14:40

feat: add method mapping json file (#1569)

5c39a00

* feat: add method mapping json file * add deleteResumableCache to mapping

fix: exported functions

4b49da7

🦉 Updates from OwlBot

976e5f2

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

test: pull testbench docker image, kokoro presubmit conformance test … (

7fc3147

#1590) * test: pull testbench docker image, kokoro presubmit conformance test hooks * use async function instead of explicit promise return * move file to node12 directory * fix file naming and linter issues

feat: check that instructions were utilized in testbench (#1601)

d3ea90f

* feat: check that instructions were utilized in testbench * feedback

fix: remove all files from bucket before delete (#1603)

ae14655

fix: create client for each test instead of globally (#1608)

c50a543

fix: remove bucketGet (#1610)

91b3fee

fix: return promise from stream functions and resolve on end (#1612)

2bb7484

fix: move createReadStream to correct mapping location (#1613)

9067e32

fix: remap bucket set storage class and bucket set metadata (#1615)

499c1c9

* fix: remap bucket set storage class * fix: remap bucketSetMetadata

fix: fixed bucketUploadMultipart (#1627)

32560df

* fix: fixed bucketUploadMultipart * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

fix: conformance test fixes for deleteFiles, fileDelete, and copy (#1636

27d9aae

) * fix: add copy to invocation map * fix: fix deleteFiles and fileDelete conformance tests * linter fixes

ddelgrosso1 force-pushed the shaffeeullah/retryConformanceTesting branch from 35c8980 to 27d9aae Compare October 6, 2021 14:53

ddelgrosso1 and others added 5 commits October 6, 2021 12:38

fix: only send metageneration to bucket related tests (#1641)

adb7819

* fix: remove tests for createWriteStream as the function is not retryable * fix: only send metageneration to bucket related tests * linter

Merge branch 'main' of github.com:googleapis/nodejs-storage into shaf…

d83e444

…feeullah/retryConformanceTesting

Merge branch 'main' of github.com:googleapis/nodejs-storage into shaf…

94793db

…feeullah/retryConformanceTesting

Merge branch 'main' of github.com:googleapis/nodejs-storage into shaf…

f803286

…feeullah/retryConformanceTesting

fix: set retention period before file creation (#1651)

686437f

* set retention period before file creation * removed log statement * removed log statement

shaffeeullah and others added 12 commits October 12, 2021 10:41

Merge branch 'main' of github.com:googleapis/nodejs-storage into shaf…

2a4bc3e

…feeullah/retryConformanceTesting

fix: combine conformance test (#1656)

c1c5048

fix: fixed storage.objects.patch tests (#1658)

effe375

* fix: fixed storage.objects.patch tests * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

fix: refactor tests (#1659)

ebc237a

* fix: refactor tests * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Merge branch 'main' of github.com:googleapis/nodejs-storage into shaf…

94ef5a0

…feeullah/retryConformanceTesting

Merge branch 'main' of github.com:googleapis/nodejs-storage into shaf…

80e36e4

…feeullah/retryConformanceTesting

chore: build headers for isPublic from interceptors (#1665)

9eabc62

* chore: build headers for isPublic from interceptors * simplify code

Merge branch 'main' of github.com:googleapis/nodejs-storage into shaf…

925b25c

…feeullah/retryConformanceTesting

tests: removed failing tests (internal issue b/203793664) (#1674)

b81be28

fix: add conformance project id (#1673)

fe0ca6a

* fix: add conformance test project id settting * lint * increase timeout for before hook * specify correct host to docker port mapping * add stop command for docker container

shaffeeullah removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 21, 2021

shaffeeullah marked this pull request as ready for review October 21, 2021 19:40

shaffeeullah requested review from a team and ddelgrosso1 October 21, 2021 19:40

shaffeeullah commented Oct 21, 2021

View reviewed changes

Comment thread conformance-test/retryStrategy.ts Outdated

shaffeeullah commented Oct 21, 2021

View reviewed changes

Comment thread conformance-test/retryStrategy.ts Outdated

chore: use import on json files instead of fs read (#1675)

b60120f

ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 21, 2021

yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 21, 2021

ddelgrosso1 approved these changes Oct 21, 2021

View reviewed changes

ddelgrosso1 merged commit d233c2b into main Oct 21, 2021

ddelgrosso1 deleted the shaffeeullah/retryConformanceTesting branch October 21, 2021 20:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: conformance testing for retries#1566

test: conformance testing for retries#1566
ddelgrosso1 merged 36 commits into
mainfrom
shaffeeullah/retryConformanceTesting

shaffeeullah commented Aug 26, 2021 •

edited

Loading

Uh oh!

generated-files-bot Bot commented Sep 21, 2021 •

edited

Loading

Uh oh!

snippet-bot Bot commented Oct 4, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

shaffeeullah commented Aug 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

generated-files-bot Bot commented Sep 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snippet-bot Bot commented Oct 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

No region tags are edited in this PR.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shaffeeullah commented Aug 26, 2021 •

edited

Loading

generated-files-bot Bot commented Sep 21, 2021 •

edited

Loading

snippet-bot Bot commented Oct 4, 2021 •

edited

Loading