Skip to content

feat(rust): support advanced_chunks option#2115

Merged
hyf0 merged 1 commit intomainfrom
09-02-feat_rust_support_advanced_chunks_option
Sep 1, 2024
Merged

feat(rust): support advanced_chunks option#2115
hyf0 merged 1 commit intomainfrom
09-02-feat_rust_support_advanced_chunks_option

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Sep 1, 2024

Description

This was referenced Sep 1, 2024
Merged
Merged
Merged
Merged
@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Sep 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 marked this pull request as ready for review September 1, 2024 17:17
@hyf0 hyf0 self-assigned this Sep 1, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 1, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(723cf99)
  • pr: 09-02-feat_rust_support_advanced_chunks_option(3e9b18a)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     52.2±1.15ms        ? ?/sec    1.06     55.4±2.23ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.01     78.9±1.50ms        ? ?/sec    1.00     78.0±1.43ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.01     95.5±1.70ms        ? ?/sec    1.00     94.2±1.63ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     60.8±0.85ms        ? ?/sec    1.03     62.6±1.43ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    101.0±1.34ms        ? ?/sec    1.03    104.2±1.33ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    185.6±9.42ms        ? ?/sec    1.03    191.5±7.10ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    225.7±3.83ms        ? ?/sec    1.07    241.9±6.53ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    116.1±0.99ms        ? ?/sec    1.02    118.1±0.97ms        ? ?/sec
bundle/bundle@threejs                                               1.00     36.4±0.75ms        ? ?/sec    1.00     36.5±0.32ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.01     82.7±1.09ms        ? ?/sec    1.00     81.8±1.79ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    101.1±2.29ms        ? ?/sec    1.01    102.6±3.02ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     45.3±0.43ms        ? ?/sec    1.03     46.7±0.31ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    387.9±4.13ms        ? ?/sec    1.01    391.9±4.11ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   989.9±10.54ms        ? ?/sec    1.00    990.6±7.65ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1249.0±13.41ms        ? ?/sec    1.00  1248.9±13.39ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    455.6±3.57ms        ? ?/sec    1.01    461.6±3.01ms        ? ?/sec
remapping/remapping                                                 1.00     33.6±0.50ms        ? ?/sec    1.03     34.4±1.15ms        ? ?/sec
remapping/render-chunk-remapping                                    1.02     87.3±0.74ms        ? ?/sec    1.00     85.3±0.69ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     81.6±0.91ms        ? ?/sec    1.02     83.3±1.30ms        ? ?/sec
scan/scan@threejs                                                   1.02     29.2±1.88ms        ? ?/sec    1.00     28.7±0.22ms        ? ?/sec
scan/scan@threejs10x                                                1.00    288.2±3.60ms        ? ?/sec    1.01    290.4±2.38ms        ? ?/sec

@hyf0 hyf0 force-pushed the 09-02-refactor_rust_code-splitting_add_chunkgraph_add_module_to_chunk_ branch from 2562a87 to 7962059 Compare September 1, 2024 18:41
Base automatically changed from 09-02-refactor_rust_code-splitting_add_chunkgraph_add_module_to_chunk_ to main September 1, 2024 19:18
@hyf0 hyf0 force-pushed the 09-02-feat_rust_support_advanced_chunks_option branch from 4707e4f to 3e9b18a Compare September 1, 2024 19:18
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 1, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 3e9b18a
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66d4be00ae25530008659bca

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Sep 1, 2024

Merge activity

  • Sep 1, 3:18 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@hyf0 hyf0 added this pull request to the merge queue Sep 1, 2024
Merged via the queue into main with commit 1a81db2 Sep 1, 2024
@hyf0 hyf0 deleted the 09-02-feat_rust_support_advanced_chunks_option branch September 1, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@hyf0 hyf0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hyf0