Skip to content

refactor(rust/code-splitting): add ChunkGraph#add_module_to_chunk#2114

Merged
hyf0 merged 1 commit intomainfrom
09-02-refactor_rust_code-splitting_add_chunkgraph_add_module_to_chunk_
Sep 1, 2024
Merged

refactor(rust/code-splitting): add ChunkGraph#add_module_to_chunk#2114
hyf0 merged 1 commit intomainfrom
09-02-refactor_rust_code-splitting_add_chunkgraph_add_module_to_chunk_

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Sep 1, 2024

Description

This was referenced Sep 1, 2024
Merged
Merged
Merged
@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Sep 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 marked this pull request as ready for review September 1, 2024 17:17
@hyf0 hyf0 mentioned this pull request Sep 1, 2024
Merged
@hyf0 hyf0 self-assigned this Sep 1, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 1, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(24a1bd1)
  • pr: 09-02-refactor_rust_code-splitting_add_chunkgraph_add_module_to_chunk_(7962059)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     52.2±0.92ms        ? ?/sec    1.00     52.3±0.82ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     74.9±1.01ms        ? ?/sec    1.00     74.6±0.85ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     92.2±1.16ms        ? ?/sec    1.00     92.4±1.27ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.02     61.1±1.50ms        ? ?/sec    1.00     60.2±0.67ms        ? ?/sec
bundle/bundle@rome-ts                                               1.01    101.1±1.08ms        ? ?/sec    1.00     99.9±0.84ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    180.7±4.05ms        ? ?/sec    1.01    182.3±3.86ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    224.3±2.69ms        ? ?/sec    1.02    228.1±5.65ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    116.9±1.65ms        ? ?/sec    1.00    116.3±2.16ms        ? ?/sec
bundle/bundle@threejs                                               1.00     36.4±0.91ms        ? ?/sec    1.00     36.3±1.39ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.01     82.4±1.05ms        ? ?/sec    1.00     81.9±0.74ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.01    104.2±2.91ms        ? ?/sec    1.00    102.7±4.65ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.01     45.8±0.28ms        ? ?/sec    1.00     45.3±0.57ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    384.0±2.56ms        ? ?/sec    1.00    383.4±3.11ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00    970.8±9.66ms        ? ?/sec    1.00    970.6±6.96ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1230.3±4.91ms        ? ?/sec    1.00   1233.3±9.22ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    454.9±6.36ms        ? ?/sec    1.00    453.5±2.33ms        ? ?/sec
remapping/remapping                                                 1.00     31.3±0.34ms        ? ?/sec    1.07     33.5±0.12ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     85.7±0.37ms        ? ?/sec    1.01     86.4±0.51ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     82.4±0.73ms        ? ?/sec    1.00     82.7±1.48ms        ? ?/sec
scan/scan@threejs                                                   1.01     28.9±0.41ms        ? ?/sec    1.00     28.7±0.79ms        ? ?/sec
scan/scan@threejs10x                                                1.00    290.5±6.30ms        ? ?/sec    1.00    291.7±1.92ms        ? ?/sec

@hyf0 hyf0 force-pushed the 09-01-refactor_rust_code-splitting_construct_chunkgraph_at_first branch from 44748e1 to 70cfbcf Compare September 1, 2024 17:53
Base automatically changed from 09-01-refactor_rust_code-splitting_construct_chunkgraph_at_first to main September 1, 2024 18:30
@hyf0 hyf0 force-pushed the 09-02-refactor_rust_code-splitting_add_chunkgraph_add_module_to_chunk_ branch from 2562a87 to 7962059 Compare September 1, 2024 18:41
@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Sep 1, 2024

Merge activity

  • Sep 1, 2:41 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 1, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 7962059
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66d4b544f074da00097d8caf

@hyf0 hyf0 added this pull request to the merge queue Sep 1, 2024
Merged via the queue into main with commit 723cf99 Sep 1, 2024
@hyf0 hyf0 deleted the 09-02-refactor_rust_code-splitting_add_chunkgraph_add_module_to_chunk_ branch September 1, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@hyf0 hyf0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hyf0