Skip to content

chore(rust): move generate_chunks fn to the top of the file#2110

Merged
hyf0 merged 1 commit intomainfrom
09-01-chore_rust_move_generate_chunks_fn_to_the_top_of_the_file
Sep 1, 2024
Merged

chore(rust): move generate_chunks fn to the top of the file#2110
hyf0 merged 1 commit intomainfrom
09-01-chore_rust_move_generate_chunks_fn_to_the_top_of_the_file

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Sep 1, 2024

Description

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Sep 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 marked this pull request as ready for review September 1, 2024 15:20
This was referenced Sep 1, 2024
Merged
Merged
@hyf0 hyf0 force-pushed the 09-01-refactor_rust_add_chunktable_ branch from 2b0e06c to 22dd858 Compare September 1, 2024 15:24
@hyf0 hyf0 force-pushed the 09-01-chore_rust_move_generate_chunks_fn_to_the_top_of_the_file branch from feb37c7 to 0c71588 Compare September 1, 2024 15:24
@hyf0 hyf0 self-assigned this Sep 1, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 1, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(70a7e80)
  • pr: 09-01-chore_rust_move_generate_chunks_fn_to_the_top_of_the_file(246ae75)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     52.6±0.86ms        ? ?/sec    1.03     54.0±2.65ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     78.2±1.57ms        ? ?/sec    1.00     78.3±0.82ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     94.9±2.03ms        ? ?/sec    1.01     95.5±1.25ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     62.2±1.41ms        ? ?/sec    1.00     61.3±1.14ms        ? ?/sec
bundle/bundle@rome-ts                                               1.02    104.1±2.80ms        ? ?/sec    1.00    102.1±1.21ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    189.6±3.44ms        ? ?/sec    1.01    191.4±5.88ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    234.0±5.12ms        ? ?/sec    1.01    236.9±6.59ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    120.6±1.51ms        ? ?/sec    1.00    120.1±1.67ms        ? ?/sec
bundle/bundle@threejs                                               1.01     36.7±0.86ms        ? ?/sec    1.00     36.4±1.13ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     84.2±1.79ms        ? ?/sec    1.02     85.6±1.26ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    101.0±1.51ms        ? ?/sec    1.03    103.6±2.20ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     46.5±0.47ms        ? ?/sec    1.01     47.0±1.06ms        ? ?/sec
bundle/bundle@threejs10x                                            1.01    392.4±2.45ms        ? ?/sec    1.00    389.9±1.54ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   995.8±10.66ms        ? ?/sec    1.00   993.9±12.01ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01  1260.1±14.50ms        ? ?/sec    1.00  1248.9±12.28ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    463.8±2.96ms        ? ?/sec    1.00    463.3±5.16ms        ? ?/sec
remapping/remapping                                                 1.00     33.7±0.23ms        ? ?/sec    1.00     33.8±0.15ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     85.7±0.49ms        ? ?/sec    1.01     86.2±0.43ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     82.4±0.99ms        ? ?/sec    1.01     83.0±1.11ms        ? ?/sec
scan/scan@threejs                                                   1.02     29.1±0.47ms        ? ?/sec    1.00     28.6±0.34ms        ? ?/sec
scan/scan@threejs10x                                                1.00    292.1±1.84ms        ? ?/sec    1.00    291.7±2.16ms        ? ?/sec

Base automatically changed from 09-01-refactor_rust_add_chunktable_ to main September 1, 2024 16:17
@hyf0 hyf0 force-pushed the 09-01-chore_rust_move_generate_chunks_fn_to_the_top_of_the_file branch from 0c71588 to 246ae75 Compare September 1, 2024 17:17
This was referenced Sep 1, 2024
Merged
Merged
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 1, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 246ae75
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66d4a190a2dc20000835cf52

@hyf0 hyf0 added this pull request to the merge queue Sep 1, 2024
Merged via the queue into main with commit a22a285 Sep 1, 2024
@hyf0 hyf0 deleted the 09-01-chore_rust_move_generate_chunks_fn_to_the_top_of_the_file branch September 1, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@hyf0 hyf0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hyf0