Skip to content

refactor(rust/code-splitting): construct ChunkGraph at first#2111

Merged
hyf0 merged 1 commit intomainfrom
09-01-refactor_rust_code-splitting_construct_chunkgraph_at_first
Sep 1, 2024
Merged

refactor(rust/code-splitting): construct ChunkGraph at first#2111
hyf0 merged 1 commit intomainfrom
09-01-refactor_rust_code-splitting_construct_chunkgraph_at_first

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Sep 1, 2024

Description

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Sep 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

This was referenced Sep 1, 2024
Merged
Merged
@hyf0 hyf0 marked this pull request as ready for review September 1, 2024 15:20
@hyf0 hyf0 force-pushed the 09-01-chore_rust_move_generate_chunks_fn_to_the_top_of_the_file branch from feb37c7 to 0c71588 Compare September 1, 2024 15:24
@hyf0 hyf0 force-pushed the 09-01-refactor_rust_code-splitting_construct_chunkgraph_at_first branch from 3d43efb to 4fb2b21 Compare September 1, 2024 15:24
@hyf0 hyf0 self-assigned this Sep 1, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 1, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(a22a285)
  • pr: 09-01-refactor_rust_code-splitting_construct_chunkgraph_at_first(70cfbcf)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     51.7±0.69ms        ? ?/sec    1.16     59.8±2.35ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     74.9±1.27ms        ? ?/sec    1.11     83.2±1.08ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     92.9±1.31ms        ? ?/sec    1.09    101.1±1.25ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     60.2±0.91ms        ? ?/sec    1.11     67.1±0.75ms        ? ?/sec
bundle/bundle@rome-ts                                               1.07    110.5±1.75ms        ? ?/sec    1.00    103.1±1.02ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.20    227.1±5.69ms        ? ?/sec    1.00    188.5±4.58ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.12    274.8±2.44ms        ? ?/sec    1.00    245.7±9.35ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.06    128.9±1.75ms        ? ?/sec    1.00    121.1±1.12ms        ? ?/sec
bundle/bundle@threejs                                               1.02     36.8±1.23ms        ? ?/sec    1.00     36.0±0.19ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     83.1±1.84ms        ? ?/sec    1.01     84.2±1.13ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    103.9±0.90ms        ? ?/sec    1.00    103.5±1.86ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.03     46.8±0.83ms        ? ?/sec    1.00     45.5±0.38ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    393.6±2.66ms        ? ?/sec    1.00    393.2±2.62ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.08  1078.7±19.05ms        ? ?/sec    1.00    994.5±8.30ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.08  1343.7±10.83ms        ? ?/sec    1.00   1246.6±8.16ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    462.9±3.02ms        ? ?/sec    1.01    467.2±8.26ms        ? ?/sec
remapping/remapping                                                 1.01     33.4±0.30ms        ? ?/sec    1.00     33.0±0.40ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     86.2±0.57ms        ? ?/sec    1.01     86.8±0.62ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     87.7±1.09ms        ? ?/sec    1.01     88.2±1.03ms        ? ?/sec
scan/scan@threejs                                                   1.00     28.7±0.80ms        ? ?/sec    1.03     29.5±1.30ms        ? ?/sec
scan/scan@threejs10x                                                1.05    305.9±2.54ms        ? ?/sec    1.00    290.1±6.96ms        ? ?/sec

@hyf0 hyf0 force-pushed the 09-01-chore_rust_move_generate_chunks_fn_to_the_top_of_the_file branch from 0c71588 to 246ae75 Compare September 1, 2024 17:17
@hyf0 hyf0 force-pushed the 09-01-refactor_rust_code-splitting_construct_chunkgraph_at_first branch from 4fb2b21 to 44748e1 Compare September 1, 2024 17:17
This was referenced Sep 1, 2024
Merged
Merged
Base automatically changed from 09-01-chore_rust_move_generate_chunks_fn_to_the_top_of_the_file to main September 1, 2024 17:53
@hyf0 hyf0 force-pushed the 09-01-refactor_rust_code-splitting_construct_chunkgraph_at_first branch from 44748e1 to 70cfbcf Compare September 1, 2024 17:53
@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Sep 1, 2024

Merge activity

  • Sep 1, 1:54 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 1, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 70cfbcf
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66d4aa2fb02ae7000886cb3b

@hyf0 hyf0 added this pull request to the merge queue Sep 1, 2024
Merged via the queue into main with commit 24a1bd1 Sep 1, 2024
@hyf0 hyf0 deleted the 09-01-refactor_rust_code-splitting_construct_chunkgraph_at_first branch September 1, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@hyf0 hyf0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hyf0