Allow multiline comments in PullRequest#2540
Merged
EnricoMi merged 27 commits intoPyGithub:masterfrom Jun 15, 2023
heitorpolidoro:fix_create_comment_issues
Merged
Allow multiline comments in PullRequest#2540EnricoMi merged 27 commits intoPyGithub:masterfrom heitorpolidoro:fix_create_comment_issues
EnricoMi merged 27 commits intoPyGithub:masterfrom
heitorpolidoro:fix_create_comment_issues
Conversation
This was referenced May 31, 2023
Closed
Contributor
Author
EnricoMi
reviewed
Jun 1, 2023
Collaborator
EnricoMi
left a comment
There was a problem hiding this comment.
Looks good, minor comments.
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Enrico Minack <github@enrico.minack.dev>
Co-authored-by: Steve Kowalik <steven@wedontsleep.org>
Note: This is a breaking change. The order of parameters of `PullRequest.get_review_comments` has changed to match other `get_comments` methods and Github API parameter order. Users should change `PullRequest.get_review_comments(since)` to `PullRequest.get_review_comments(since=since)`. Calling without parameter is not breaking: `PullRequest.get_review_comments()`
This adds argument `auth` and deprecates `login_or_token`, `password`, `jwt`, and `app_auth` arguments of `github.Github`. This adds argument `auth` and deprecates `integration_id`, `private_key` of `github.GithubIntegration`. This deprecates the `create_jwt` method of `github.GithubIntegration`, replaced by `github.Auth.AppAuth.create_jwt`.
…ven (#2543) Fixes slug attribute to fetch app when not set. Loads app with slug lazily, fetch complete app without slug.
Allows to refresh Github App user token. Integrates `ApplicationOAuth` into `github.Auth`.
…st for 'as_suggestion'
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2540 +/- ##
==========================================
+ Coverage 98.47% 98.50% +0.02%
==========================================
Files 128 128
Lines 12733 12751 +18
==========================================
+ Hits 12539 12560 +21
+ Misses 194 191 -3
☔ View full report in Codecov by Sentry. |
EnricoMi
requested changes
Jun 15, 2023
fix(PullRequest.create_review_comment): Change default from None to NotSet Co-authored-by: Enrico Minack <github@enrico.minack.dev>
…otSet Co-authored-by: Enrico Minack <github@enrico.minack.dev>
…10254c2 …otSet Co-authored-by: Enrico Minack <github@enrico.minack.dev>
EnricoMi
approved these changes
Jun 15, 2023
Collaborator
EnricoMi
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change deprecated parameter: position -> line
add a parameter to allow multiline comment: start_line
add a parameter to allow comment as suggestion: as_suggestion