Add name, display_title and path attributes to WorkflowRun#2397
Add name, display_title and path attributes to WorkflowRun#2397EnricoMi merged 11 commits intoPyGithub:masterfrom
name, display_title and path attributes to WorkflowRun#2397Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2397 +/- ##
==========================================
+ Coverage 98.66% 98.81% +0.15%
==========================================
Files 117 117
Lines 11794 11695 -99
==========================================
- Hits 11636 11556 -80
+ Misses 158 139 -19
☔ View full report in Codecov by Sentry. |
EnricoMi
left a comment
There was a problem hiding this comment.
@sfdye @s-t-e-v-e-n-k this looks pretty straight forward and non-controversal
You could easily target your personal public repository, that should be as good as any other repo. |
|
Sorry for late response, I'll work on your suggestions on my free time. Thanks! |
69f527b to
14e3001
Compare
WorkflowRunname, display_title and path attributes to WorkflowRun
Introduce new attributes of
WorkflowRun- see "Response Schema" of Get a workflow runAdded attributes:
By the way, I tried to record new
ReplayData, since existing ones were outdated thus not containing those attributes,But since I don't have sufficient permissions on this repository, so some tests are failing.
Could I ask a favor to maintainers (or whom that has permissions) to record & update the
ReplayDatainstead of me?Or can I just change the assertion value, assuming that tests can be run by users with insufficient permission like me?