Add sort order and direction for getting comments#2544
Merged
EnricoMi merged 5 commits intoPyGithub:masterfrom Jun 7, 2023
Merged
Add sort order and direction for getting comments#2544EnricoMi merged 5 commits intoPyGithub:masterfrom
EnricoMi merged 5 commits intoPyGithub:masterfrom
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2544 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 117 117
Lines 11825 11831 +6
=======================================
+ Hits 11670 11676 +6
Misses 155 155
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some methods getting comments miss sort query parameters.
Note: This is a breaking change. The order of parameters of
PullRequest.get_review_commentshas changed to match otherget_commentsmethods and Github API parameter order. Users should changePullRequest.get_review_comments(since)toPullRequest.get_review_comments(since=since).Calling without parameter is not breaking:
PullRequest.get_review_comments()