Skip to content

Implement AppUserAuth for Github App user tokens#2546

Merged
EnricoMi merged 9 commits intoPyGithub:masterfrom
EnricoMi:implement-app-user-auth
Jun 14, 2023
Merged

Implement AppUserAuth for Github App user tokens#2546
EnricoMi merged 9 commits intoPyGithub:masterfrom
EnricoMi:implement-app-user-auth

Conversation

@EnricoMi
Copy link
Collaborator

@EnricoMi EnricoMi commented Jun 8, 2023

Allows to refresh Github App user token. Integrates ApplicationOAuth into github.Auth.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Patch coverage: 96.35% and project coverage change: +0.01 🎉

Comparison is base (7be3f76) 98.49% compared to head (73629aa) 98.50%.

❗ Current head 73629aa differs from pull request most recent head fbb90bf. Consider uploading reports for the commit fbb90bf to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2546      +/-   ##
==========================================
+ Coverage   98.49%   98.50%   +0.01%     
==========================================
  Files         124      124              
  Lines       12418    12538     +120     
==========================================
+ Hits        12231    12351     +120     
  Misses        187      187              
Impacted Files Coverage Δ
github/Auth.py 93.27% <93.67%> (+2.07%) ⬆️
github/AccessToken.py 100.00% <100.00%> (ø)
github/ApplicationOAuth.py 98.30% <100.00%> (+0.57%) ⬆️
github/Requester.py 98.28% <100.00%> (+0.28%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@EnricoMi
Copy link
Collaborator Author

EnricoMi commented Jun 8, 2023

CC @rigaspapas

@EnricoMi EnricoMi requested a review from JLLeitschuh June 8, 2023 07:24
@EnricoMi EnricoMi changed the title Implement AppUserAuth Implement AppUserAuth for Github App user tokens Jun 8, 2023
@EnricoMi EnricoMi force-pushed the implement-app-user-auth branch from bacd366 to 25abc49 Compare June 8, 2023 08:09
Copy link
Collaborator

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I can review this on substance, but looks good to me!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this file is so small, you could likely delete it and just put the types on the implementation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I started this, but this unveiled lots of typing warnings, discussed and to be fixed here: #2463 (comment)

@EnricoMi EnricoMi force-pushed the implement-app-user-auth branch 2 times, most recently from 73629aa to fbb90bf Compare June 13, 2023 10:11
@EnricoMi EnricoMi force-pushed the implement-app-user-auth branch from fbb90bf to 27deee2 Compare June 14, 2023 17:28
@EnricoMi EnricoMi merged commit f291a36 into PyGithub:master Jun 14, 2023
@EnricoMi EnricoMi deleted the implement-app-user-auth branch June 14, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants