perf(napi/parser, linter/plugins): inline trivial raw transfer field deserializers into node object definitions by overlookmotel · Pull Request #21134 · oxc-project/oxc

overlookmotel · 2026-04-07T15:40:44Z

Utilize the #[estree(raw_deser_inline)] attribute introduced in #21134 to mark all custom deserializers which do not depend on parent as inline-able.

This reduces deserializer code size, as well as being more performant in some cases, by avoiding write boundary checks.

overlookmotel · 2026-04-07T15:41:00Z

perf(napi/parser, linter/plugins): raw transfer deserializer for Vecs use shift instead of multiply where possible #21142
perf(napi/parser, linter/plugins): shift before add when calculating positions in raw transfer deserializer #21141
perf(napi/parser, linter/plugins): remove uint32 buffer view #21140
perf(napi/parser): lazy deserialization use only Int32Array #21139
perf(napi/parser): deserializing tokens use only int32 array #21138
perf(parser): tokens raw deserialization use Int32Array #21137
perf(linter/plugins): use Int32Arrays for tokens and comments buffers #21136
perf(napi/parser, linter/plugins): raw transfer deserialize Span fields as i32s #21135
perf(napi/parser, linter/plugins): inline trivial raw transfer field deserializers into node object definitions #21134 👈 (View in Graphite)
feat(ast_tools): support inlining custom deserialized fields with #[estree(raw_deser_inline)] #21133
perf(napi/parser, linter/plugins): use Int32Array in raw transfer deserializer #21132
refactor(napi/parser, linter/plugins): add int32 buffer view #21131
docs(linter/plugins): correct comments #21130
perf(linter/plugins): use >> not >>> in binary search loops #21129
test(napi/parser): fix benchmarks #21128
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-04-07T15:47:58Z

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing om/04-07-perf_napi_parser_linter_plugins_inline_trivial_raw_transfer_field_deserializers_into_node_object_definitions (b38ccca) with main (c5c8c03)²}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on om/04-07-feat_ast_tools_support_inlining_custom_deserialized_fields_with_estree_raw_deser_inline_ (0626c79) during the generation of this report, so main (c5c8c03) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull request overview

This PR applies the newly introduced #[estree(raw_deser_inline)] capability to “trivial” raw-transfer field deserializers so they can be emitted directly inside node object literals instead of as post-creation assignments, reducing generated deserializer code size and avoiding some boundary checks.

Changes:

Marked a set of converter/meta fields as raw_deser_inline in crates/oxc_ast (constants, simple expressions, and small preamble-based converters like BigInt parsing).
Regenerated N-API parser JS/TS raw-transfer deserializers to inline constant/default fields (e.g., optional: false, computed: true/false, decorators: [], "init", "in", "global", "value").
Regenerated the oxlint JS deserializer similarly (including NodeProto + parent variants).

Reviewed changes

Copilot reviewed 5 out of 14 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
napi/parser/src-js/generated/deserialize/ts.js	Inlines trivial/default field values into node object literals for TS deserializer variant.
napi/parser/src-js/generated/deserialize/ts_range.js	Same as above, for TS + `range` variant.
napi/parser/src-js/generated/deserialize/ts_range_parent.js	Same as above, for TS + `range` + `parent` variant; leaf nodes now return directly without temporary `parent` reassignment.
napi/parser/src-js/generated/deserialize/ts_parent.js	Same as above, for TS + `parent` variant; leaf nodes now return directly without temporary `parent` reassignment.
napi/parser/src-js/generated/deserialize/js.js	Inlines trivial/default field values into node object literals for JS deserializer variant.
napi/parser/src-js/generated/deserialize/js_range.js	Same as above, for JS + `range` variant.
napi/parser/src-js/generated/deserialize/js_range_parent.js	Same as above, for JS + `range` + `parent` variant.
napi/parser/src-js/generated/deserialize/js_parent.js	Same as above, for JS + `parent` variant.
crates/oxc_ast/src/serialize/ts.rs	Marks TS-specific meta converters as inlineable (e.g., `TSEnumMember.computed`, TS-only directive null).
crates/oxc_ast/src/serialize/mod.rs	Marks `CommentValue` raw deserializer as inlineable.
crates/oxc_ast/src/serialize/literal.rs	Marks `NullLiteral.raw`, `BigIntLiteral.value`, and `BigIntLiteral.bigint` converters as inlineable.
crates/oxc_ast/src/serialize/jsx.rs	Marks `JSXOpeningElement.selfClosing` default raw deserializer as inlineable.
crates/oxc_ast/src/serialize/basic.rs	Marks multiple constant/meta helpers (`Null`, `True/False`, `Init`, `In`, `This`, `Global`, `EmptyArray`, etc.) as inlineable.
apps/oxlint/src-js/generated/deserialize.js	Regenerated oxlint deserializer to inline trivial/default fields inside node literals (including `NodeProto` + `parent`).

graphite-app · 2026-04-07T17:24:23Z

Merge activity

Apr 7, 5:24 PM UTC: graphite-app added this pull request to the Graphite merge queue.
Apr 7, 5:36 PM UTC: Merged by the Graphite merge queue.

…deserializers into node object definitions (#21134) Utilize the `#[estree(raw_deser_inline)]` attribute introduced in #21134 to mark all custom deserializers which do not depend on `parent` as inline-able. This reduces deserializer code size, as well as being more performant in some cases, by avoiding write boundary checks.

### 💥 BREAKING CHANGES - 36cdc31 str: [**BREAKING**] Remove identity `FromIn` impl for `Ident` (#21251) (overlookmotel) - 382958a span: [**BREAKING**] Remove re-exports of string types from `oxc_span` crate (#21246) (overlookmotel) - c4aedfa str: [**BREAKING**] Add `static_ident!` macro (#21245) (overlookmotel) ### 🚀 Features - e7e1aea transformer/typescript: Add `optimize_enums` option for regular enum inlining (#20539) (Dunqing) - 679f57f transformer/typescript: Implement const enum inlining and declaration removal (#20508) (Dunqing) - 6dd061c semantic: Extend `MemberWriteTarget` to cover all property modification patterns (#21205) (Dunqing) - f134e24 minifier: Support `property_write_side_effects` option to drop unused property assignments (#20773) (Dunqing) - 75663c0 semantic: Add enum member value evaluation for const enum support (#20602) (Dunqing) - 3cfe8ed semantic: Add `MemberWriteTarget` flag to `ReferenceFlags` (#20772) (Dunqing) ### 🐛 Bug Fixes - af1a586 transformer/class-properties: Use correct property name when converting parameter properties (#21268) (Amal Jossy) - b43250a allocator: Move allocation tracking into `Bump` (#21342) (overlookmotel) - 36f505f allocator: `StringBuilder` use `Allocator::alloc_layout` (#21340) (overlookmotel) - 7a08a6f allocator: Fix allocation counting in `Allocator::alloc_concat_strs_array` (#21336) (overlookmotel) - 2338e28 ecmascript: Treat `this` as potentially having side effects (#21297) (sapphi-red) - bd8bd39 allocator: Remove unsafe hacks from `from_raw_parts` methods (#21283) (overlookmotel) - 8f4c340 allocator: Remove dangerous pointer const to mut cast (#21279) (overlookmotel) - aa9259f parser: Add missing error code for optional param diagnostic (#21258) (camc314) - 04b3c2f str: Fix unsound casting const pointers to mut pointers (#21242) (overlookmotel) - ceadf6c str: Make `Ident::from_raw` an unsafe function (#21241) (overlookmotel) - eab13b3 transformer/decorators: Avoid accessor storage name collisions (#21106) (Dunqing) - 07e8a30 transformer/react-refresh: Handle parenthesized variable initializers (#21047) (camc314) ### ⚡ Performance - c3ca6f6 allocator: `StringBuilder::from_strs_array_in` check for 0 length earlier (#21338) (overlookmotel) - c2422bb allocator: `Allocator::alloc_concat_strs_array` check for 0 length earlier (#21337) (overlookmotel) - 04b0fdc allocator: Mark `Allocator::alloc_layout` as `#[inline(always)]` (#21335) (overlookmotel) - 17aee9e allocator: Use `offset_from_unsigned` in `ChunkFooter::as_raw_parts` (#21280) (overlookmotel) - 61adedd minifier: Fix O(n²) perf on very many var decls (#21062) (Gunnlaugur Thor Briem) - addcd02 napi/parser, linter/plugins: Raw transfer deserializer for `Vec`s use shift instead of multiply where possible (#21142) (overlookmotel) - 3068ded napi/parser, linter/plugins: Shift before add when calculating positions in raw transfer deserializer (#21141) (overlookmotel) - eb400b8 napi/parser, linter/plugins: Remove `uint32` buffer view (#21140) (overlookmotel) - 2675085 napi/parser: Lazy deserialization use only `Int32Array` (#21139) (overlookmotel) - 5b35a53 napi/parser: Deserializing tokens use only `int32` array (#21138) (overlookmotel) - f163d10 parser: Tokens raw deserialization use `Int32Array` (#21137) (overlookmotel) - 7a86613 linter/plugins: Use `Int32Array`s for tokens and comments buffers (#21136) (overlookmotel) - 8c51121 napi/parser, linter/plugins: Raw transfer deserialize `Span` fields as `i32`s (#21135) (overlookmotel) - bc1bcdd napi/parser, linter/plugins: Inline trivial raw transfer field deserializers into node object definitions (#21134) (overlookmotel) - c0278ab napi/parser, linter/plugins: Use `Int32Array` in raw transfer deserializer (#21132) (overlookmotel) - 43482c7 linter/plugins: Use `>>` not `>>>` in binary search loops (#21129) (overlookmotel) ### 📚 Documentation - f5e1845 allocator: Upgrade headers in doc comments for `Bump` (#21263) (overlookmotel) - 2870174 allocator: Upper case `SAFETY` in comments (#21253) (overlookmotel) - 01bc269 str: Reformat `Ident` doc comments (#21240) (overlookmotel) - dd47359 allocator: Add doc comments for panics and errors (#21230) (overlookmotel)

# Oxlint ### 💥 BREAKING CHANGES - 382958a span: [**BREAKING**] Remove re-exports of string types from `oxc_span` crate (#21246) (overlookmotel) - c4aedfa str: [**BREAKING**] Add `static_ident!` macro (#21245) (overlookmotel) - 7354f3c linter: [**BREAKING**] Error on no matched files (#21144) (camc314) ### 🚀 Features - 91f2c79 linter/eslint-jest-plugin: Implemented `prefer-importing-jest-globals` rule (#21303) (Said Atrahouch) - a02f32c linter: Add release version for existing rules (#21363) (camchenry) - b9e93da linter: Allow tagging rules with release version (#21362) (camchenry) - f99ecda oxlint: Gate `vite.config.ts` recognition behind `VP_VERSION` env var (#21298) (leaysgur) - cf459d3 linter: Implement suggestion for `no-empty-function` rule (#21347) (Mikhail Baev) - 7213d61 linter: Adding pending suggestions fix to `valid_expect` rules. (#21249) (Said Atrahouch) - ae45312 linter: Introduce `--type-check-only` flag (#21184) (camc314) - 1ce8b90 linter: Implemented `valid-expect-in-promise` vitest and jest rule (#21170) (Said Atrahouch) - 39f7fda linter: Add auto-fix to `unicorn/prefer-default-parameters` (#21166) (yefan) - 15574bc linter/unicorn: Implement consistent-template-literal-escape (#21126) (AliceLanniste) - c5c8c03 linter/prefer-readonly-parameter-types: Move rule from nursery to pedantic (#21114) (camc314) - 1893be1 linter/no-useless-default-assignment: Move rule from nursery to correctness (#21113) (camc314) - 5462ff9 linter/strict-void-return: Move rule from nursery to pedantic (#21115) (camc314) - c2989bd linter/no-unnecessary-type-parameters: Move rule from nursery to suspicious (#21112) (camc314) - 79d339a linter/no-unnecessary-qualifier: Move rule from nursery to style (#21111) (camc314) ### 🐛 Bug Fixes - b577efc linter/unicorn: Handle optional chaining in `prefer-array-flat` and `no-invalid-remove-event-listener` (#21299) (Mikhail Baev) - 5e55735 oxlint/lsp: Skip .git directories in LSP walkers (#21316) (camc314) - ec7f6ed oxlint, oxfmt: Apply `check_for_writer_error` to `.flush()` (#21343) (Craig Morrison) - a17a08a linter/no-useless-assignment: Handle continue edges in loop analysis (#21358) (camc314) - a0eac12 linter/array-type: Move match to first stmt (#21357) (camc314) - 1b3abc3 linter: Exclude boundary tokens from JSXText whitespace check in isSpaceBetweenTokens (#21313) (bab) - ecbcf5e linter: More info to summary output for GitHub formatter (#21330) (Théo LUDWIG) - a0a8c62 linter/no-fallthrough: Check from start of switch case for empty lines (#21324) (Josh Cartmell) - 36f0bc4 linter/no-cycle: Report all cyclic dependencies inside a file (#21259) (camc314) - 3f80536 linter: Ignore regex flags other than `g`/`u`/`v` in `prefer-string-replace-all` (#21203) (bab) - f21d3aa linter/unicorn: Report on optional in `require-number-to-fixed-digits-argument` rule (#21207) (Mikhail Baev) - af8e122 linter: Render each config error as a separate diagnostic (#21120) (bab) - a950f55 linter/unicorn: Do not report on optionals in `no-single-promise-in-promise-methods` (#21157) (Mikhail Baev) - 472f8ee linter: Mark complete comment for unused disable directives + lsp fix (#21092) (copilot-swe-agent) - edd0865 linter/no-array-index-key: False positive when index is inside an expression within a template literal (#21123) (bab) - 7e8d520 linter/unicorn: Report on optional `foo?.postMessage` in `require-post-message-target-origin` rule (#21104) (Mikhail Baev) ### ⚡ Performance - addcd02 napi/parser, linter/plugins: Raw transfer deserializer for `Vec`s use shift instead of multiply where possible (#21142) (overlookmotel) - 3068ded napi/parser, linter/plugins: Shift before add when calculating positions in raw transfer deserializer (#21141) (overlookmotel) - eb400b8 napi/parser, linter/plugins: Remove `uint32` buffer view (#21140) (overlookmotel) - 7a86613 linter/plugins: Use `Int32Array`s for tokens and comments buffers (#21136) (overlookmotel) - 8c51121 napi/parser, linter/plugins: Raw transfer deserialize `Span` fields as `i32`s (#21135) (overlookmotel) - bc1bcdd napi/parser, linter/plugins: Inline trivial raw transfer field deserializers into node object definitions (#21134) (overlookmotel) - c0278ab napi/parser, linter/plugins: Use `Int32Array` in raw transfer deserializer (#21132) (overlookmotel) - 43482c7 linter/plugins: Use `>>` not `>>>` in binary search loops (#21129) (overlookmotel) ### 📚 Documentation - 7888280 linter: Move config docs for `no-restricted-exports` (#21360) (camchenry) - 162d26c linter: Improve docs for `typescript/array-type` (#21356) (camchenry) - a2dbaec linter: Add missing docs for options for `typescript/class-literal-property-style` (#21355) (camchenry) - 79593eb linter: Improve docs for `typescript/consistent-type-assertions` (#21353) (camchenry) - f9d20d2 linter: Move config option docs for `typescript/no-empty-object-type` (#21352) (camchenry) - a8f650d linter: Add missing config option docs for `prefer-string-start-ends-with` (#21332) (camchenry) - cfd8a4f linter: Don't rely on old eslint doc for available globals (#21334) (Nicolas Le Cam) - 03865fa linter: Jest/prefer-snapshot-hint: add doc comment for snapshot hint mode (#21290) (camchenry) - a6fe09b linter: Add missing docs for config options in `react` plugin (#21289) (camchenry) - 60eaf47 linter: Add missing docs for config options in unicorn plugin (#21288) (camchenry) - c3c2055 linter: `jsx-a11y/label-has-associated-control`: document the `assert` options (#21287) (camchenry) - a928ed9 linter: Add missing config docs for vitest plugin rules (#21285) (camchenry) - 7e07c7c linter: `id-length`: move enum docs to doc comments (#21281) (camchenry) - 9746bdf linter: Add missing docs for `class-methods-use-this` config (#21278) (camchenry) - 6ffe7a5 linter: Move docs for `Target` variant onto enum (#21277) (camchenry) - 305350d linter/plugins: Correct comments (#21130) (overlookmotel) # Oxfmt ### 💥 BREAKING CHANGES - 382958a span: [**BREAKING**] Remove re-exports of string types from `oxc_span` crate (#21246) (overlookmotel) ### 🚀 Features - e3081e1 oxfmt: Gate `vite.config.ts` recognition behind `VP_VERSION` env var (#21295) (leaysgur) - 5b0b573 oxfmt: Update prettier to 3.8.2 (#21294) (leaysgur) - 0d67834 oxfmt: Show hint for all files are ignored case (#21154) (leaysgur) ### 🐛 Bug Fixes - 2871fc2 oxfmt: Non idempotent formatting on comments in TS (#20449) (Cat Chen) - ec7f6ed oxlint, oxfmt: Apply `check_for_writer_error` to `.flush()` (#21343) (Craig Morrison) - 1a8c225 formatter: Preserve newline between self-closing JSX element and single-char text (#21149) (Justin Mecham) - 407b725 oxfmt: Indent dangling comments in empty enum with block indent (#21163) (Leonabcd123) - d13fd37 formatter: Remove extra outer parentheses on return with JSDoc type cast (#21109) (bab) - 22babde oxfmt: Fix unicode char escaping (#21162) (leaysgur) - 4da53e5 formatter: Preserve trailing comma in TSX arrow functions with default type params (#21151) (Justin Mecham) - 94fe774 oxfmt: Handle paths with consecutive leading slashes (#21155) (leaysgur) - 50c389b oxfmt: Support `.editorconfig` `quote_type` (#20989) (leaysgur) ### ⚡ Performance - 0ce619f formatter: Use `Allocator::alloc_concat_strs_array` instead of `StringBuilder::from_strs_array_in` (#21339) (overlookmotel)

overlookmotel mentioned this pull request Apr 7, 2026

perf(napi/parser, linter/plugins): raw transfer deserialize Span fields as i32s #21135

Merged

github-actions Bot added A-linter Area - Linter A-parser Area - Parser A-cli Area - CLI A-ast Area - AST A-linter-plugins Area - Linter JS plugins labels Apr 7, 2026

overlookmotel mentioned this pull request Apr 7, 2026

perf(linter/plugins): use Int32Arrays for tokens and comments buffers #21136

Merged

github-actions Bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Apr 7, 2026

overlookmotel marked this pull request as ready for review April 7, 2026 15:59

overlookmotel requested a review from camc314 as a code owner April 7, 2026 15:59

Copilot AI review requested due to automatic review settings April 7, 2026 15:59

Copilot started reviewing on behalf of overlookmotel April 7, 2026 15:59 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

overlookmotel self-assigned this Apr 7, 2026

overlookmotel force-pushed the om/04-07-feat_ast_tools_support_inlining_custom_deserialized_fields_with_estree_raw_deser_inline_ branch from 34ca616 to 68caa55 Compare April 7, 2026 16:27

overlookmotel force-pushed the om/04-07-perf_napi_parser_linter_plugins_inline_trivial_raw_transfer_field_deserializers_into_node_object_definitions branch from 4a37657 to 56a50ff Compare April 7, 2026 16:27

overlookmotel force-pushed the om/04-07-perf_napi_parser_linter_plugins_inline_trivial_raw_transfer_field_deserializers_into_node_object_definitions branch from 56a50ff to b38ccca Compare April 7, 2026 16:39

overlookmotel force-pushed the om/04-07-feat_ast_tools_support_inlining_custom_deserialized_fields_with_estree_raw_deser_inline_ branch from 68caa55 to 0626c79 Compare April 7, 2026 16:39

graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Apr 7, 2026

graphite-app Bot force-pushed the om/04-07-feat_ast_tools_support_inlining_custom_deserialized_fields_with_estree_raw_deser_inline_ branch from 0626c79 to 25ba749 Compare April 7, 2026 17:18

graphite-app Bot force-pushed the om/04-07-perf_napi_parser_linter_plugins_inline_trivial_raw_transfer_field_deserializers_into_node_object_definitions branch from b38ccca to eda0d88 Compare April 7, 2026 17:18

graphite-app Bot force-pushed the om/04-07-feat_ast_tools_support_inlining_custom_deserialized_fields_with_estree_raw_deser_inline_ branch from 25ba749 to 7b3d5a9 Compare April 7, 2026 17:27

graphite-app Bot force-pushed the om/04-07-perf_napi_parser_linter_plugins_inline_trivial_raw_transfer_field_deserializers_into_node_object_definitions branch from eda0d88 to bc1bcdd Compare April 7, 2026 17:28

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Apr 7, 2026

Base automatically changed from om/04-07-feat_ast_tools_support_inlining_custom_deserialized_fields_with_estree_raw_deser_inline_ to main April 7, 2026 17:34

graphite-app Bot merged commit bc1bcdd into main Apr 7, 2026
27 checks passed

graphite-app Bot deleted the om/04-07-perf_napi_parser_linter_plugins_inline_trivial_raw_transfer_field_deserializers_into_node_object_definitions branch April 7, 2026 17:36

This was referenced Apr 13, 2026

release(crates): oxc v0.125.0 #21374

Merged

release(apps): oxlint v1.60.0 && oxfmt v0.45.0 #21375

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf(napi/parser, linter/plugins): inline trivial raw transfer field deserializers into node object definitions#21134

perf(napi/parser, linter/plugins): inline trivial raw transfer field deserializers into node object definitions#21134
graphite-app[bot] merged 1 commit intomainfrom
om/04-07-perf_napi_parser_linter_plugins_inline_trivial_raw_transfer_field_deserializers_into_node_object_definitions

overlookmotel commented Apr 7, 2026 •

edited

Loading

Uh oh!

overlookmotel commented Apr 7, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app Bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

overlookmotel commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq Bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

graphite-app Bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

overlookmotel commented Apr 7, 2026 •

edited

Loading

overlookmotel commented Apr 7, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 7, 2026 •

edited

Loading

graphite-app Bot commented Apr 7, 2026 •

edited

Loading